Feature/system.text.json (#156)

CryptoExchange.Net V7.1.0
JKorf · Mar 16, 2024 · 10af129 · 10af129
1 parent f01c88d
commit 10af129
Show file tree

Hide file tree

Showing 21 changed files with 202 additions and 163 deletions.
diff --git a/Bitfinex.Net.UnitTests/Bitfinex.Net.UnitTests.csproj b/Bitfinex.Net.UnitTests/Bitfinex.Net.UnitTests.csproj
@@ -7,10 +7,10 @@
   </PropertyGroup>
 
   <ItemGroup>
-    <packagereference Include="Microsoft.NET.Test.Sdk" Version="16.10.0"></packagereference>
-    <PackageReference Include="Moq" Version="4.16.1" />
-    <packagereference Include="NUnit" Version="3.13.2"></packagereference>
-    <packagereference Include="NUnit3TestAdapter" Version="3.17.0"></packagereference>
+    <packagereference Include="Microsoft.NET.Test.Sdk" Version="17.9.0"></packagereference>
+    <PackageReference Include="Moq" Version="4.20.70" />
+    <packagereference Include="NUnit" Version="4.1.0"></packagereference>
+    <packagereference Include="NUnit3TestAdapter" Version="4.5.0"></packagereference>
   </ItemGroup>
 
   <ItemGroup>

diff --git a/Bitfinex.Net.UnitTests/BitfinexClientTests.cs b/Bitfinex.Net.UnitTests/BitfinexClientTests.cs
@@ -15,6 +15,7 @@
 using Bitfinex.Net.Clients;
 using Bitfinex.Net.ExtensionMethods;
 using CryptoExchange.Net.Objects.Sockets;
+using NUnit.Framework.Legacy;
 
 namespace Bitfinex.Net.UnitTests
 {
@@ -31,9 +32,9 @@ public async Task ReceivingHttpError_Should_ResultInErrorResult()
             var result = await client.SpotApi.ExchangeData.GetAssetFullNamesAsync();
 
             // assert
-            Assert.AreEqual(false, result.Success);
-            Assert.IsTrue(result.Error.ToString().Contains("Error message"));
-            Assert.AreEqual(HttpStatusCode.BadRequest, result.ResponseStatusCode);
+            Assert.That(false == result.Success);
+            Assert.That(result.Error.ToString().Contains("Error message"));
+            Assert.That(HttpStatusCode.BadRequest == result.ResponseStatusCode);
         }
 
 
@@ -45,7 +46,7 @@ public void ProvidingApiCredentials_Should_SaveApiCredentials()
             var authProvider = new BitfinexAuthenticationProvider(new ApiCredentials("TestKey", "TestSecret"), null);
 
             // assert
-            Assert.AreEqual(authProvider.GetApiKey(), "TestKey");
+            Assert.That(authProvider.GetApiKey() == "TestKey");
         }
 
         [Test]
@@ -58,7 +59,7 @@ public void SigningString_Should_ReturnCorrectString()
             string signed = authProvider.Sign("SomeTestString");
 
             // assert
-            Assert.AreEqual(signed, "9052C73092B21B945BC5859CADBA6A5658E142F021FCB092A72F68E8A0D5E6351CFEBAE52DB9067D4360F796CB520960");
+            Assert.That(signed == "9052C73092B21B945BC5859CADBA6A5658E142F021FCB092A72F68E8A0D5E6351CFEBAE52DB9067D4360F796CB520960");
         }
 
         [Test]
@@ -112,7 +113,7 @@ public void CheckRestInterfaces()
                 foreach (var method in implementation.GetMethods().Where(m => m.ReturnType.IsAssignableTo(typeof(Task))))
                 {
                     var interfaceMethod = clientInterface.GetMethod(method.Name, method.GetParameters().Select(p => p.ParameterType).ToArray());
-                    Assert.NotNull(interfaceMethod, $"Missing interface for method {method.Name} in {implementation.Name} implementing interface {clientInterface.Name}");
+                    ClassicAssert.NotNull(interfaceMethod, $"Missing interface for method {method.Name} in {implementation.Name} implementing interface {clientInterface.Name}");
                     methods++;
                 }
                 Debug.WriteLine($"{clientInterface.Name} {methods} methods validated");
@@ -132,7 +133,7 @@ public void CheckSocketInterfaces()
                 foreach (var method in implementation.GetMethods().Where(m => m.ReturnType.IsAssignableTo(typeof(Task<CallResult<UpdateSubscription>>))))
                 {
                     var interfaceMethod = clientInterface.GetMethod(method.Name, method.GetParameters().Select(p => p.ParameterType).ToArray());
-                    Assert.NotNull(interfaceMethod, $"Missing interface for method {method.Name} in {implementation.Name} implementing interface {clientInterface.Name}");
+                    ClassicAssert.NotNull(interfaceMethod, $"Missing interface for method {method.Name} in {implementation.Name} implementing interface {clientInterface.Name}");
                     methods++;
                 }
                 Debug.WriteLine($"{clientInterface.Name} {methods} methods validated");