Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated default KtLint version to 1.5.0 #818

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Updated default KtLint version to 1.5.0 #818

wants to merge 1 commit into from

Conversation

CPColin
Copy link

@CPColin CPColin commented Dec 9, 2024

No description provided.

@CPColin CPColin mentioned this pull request Dec 9, 2024
Open
qmg-cherryl
qmg-cherryl approved these changes Dec 10, 2024
View reviewed changes
Copy link

@qmg-cherryl qmg-cherryl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JonasKellerer JonasKellerer mentioned this pull request Dec 10, 2024
Open
@CPColin
Copy link
Author

CPColin commented Dec 15, 2024

I see your approvals, but GitHub isn't showing me a Merge button.

@wakingrufus
Copy link
Collaborator

This PR doesnt actually change the default version. only the version that the ktlint-gradle itself uses
We consider changing the default version a breaking change, since behavior will change for most users, so I am working on some other breaking changes we want to get in for the next major bump first, then I will come back to this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qmg-cherryl qmg-cherryl qmg-cherryl approved these changes

@wickenico wickenico wickenico approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@CPColin @wakingrufus @wickenico @qmg-cherryl