Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Linker and Scope toString + tests #156

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

TWiStErRob
Copy link
Contributor

Fixes:

reflect\src\main\java\dagger\reflect\Scope.java:84:
warning: [ObjectToString] Linker is final and does not override Object.toString, so converting it to a string will print its identity (e.g. `Linker@ 4488aabb`) instead of useful information
.
            "Unable to find binding for key=" + key + " with linker=" + linker);
                                                                        ^
    (see https://errorprone.info/bugpattern/ObjectToString)

@@ -158,6 +158,24 @@ public void optionalBindingNullable() {
}
}

@Test
@IgnoreCodegen
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is actually compiling and working in codegen, but this test would fail at fail() with codegen.
I couldn't find any repro other than OptionalBindingWrongScope where linker was not null, any ideas?

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I merged the first two commits while I think about this more.

I didn't realize qualifier annotations on types actually worked...

@TWiStErRob TWiStErRob mentioned this pull request Aug 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants