always add always_false() clause when tally contains a deduct #414
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The logic:
Would generate the code:
This would clamp the number of times
good()
could be tallied to 5, so if anybad()
s were tallied, the logic would never be true.The correct code would be:
Which allows
good()
to be tallied more than 5 times to counteract any deductions made bybad()
. If There needs to be a limit ongood()
, it can be wrapped in it's ownrepeated()
.