Skip to content
This repository has been archived by the owner on Mar 10, 2022. It is now read-only.

Add zsh support for direnv #24

Open
wants to merge 1 commit into
base: stable
Choose a base branch
from
Open

Conversation

mrylmz
Copy link

@mrylmz mrylmz commented Jun 21, 2019

No description provided.

@mrylmz mrylmz requested a review from Jeehut June 21, 2019 08:18
@Jeehut
Copy link
Contributor

Jeehut commented Jun 21, 2019

Looks good to me. Did you also make sure this works in default terminal on macOS prior to 10.15 beta and that it also works with iTerm (using bash)?

@mrylmz
Copy link
Author

mrylmz commented Jun 21, 2019

I'll test this with bash, we could also emit the new version only into the .zshrc file then we could guarantee backward compatibility...

@@ -46,7 +46,7 @@ public func link() throws {

for bashConfigFile in [".bash_profile", ".bashrc", ".profile"] {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You forgot to add the zsh configuration file to the array here. It should be created if not already existent.

@Jeehut
Copy link
Contributor

Jeehut commented Jun 21, 2019

Yes, if $SHELL doesn't work for bash, then we could do that. But my guess is that it will work fine, we just need to test it before merging.

@mrylmz
Copy link
Author

mrylmz commented Jun 21, 2019

We also have a problem with the beak run link script. If the script has been executed before then the script will write the same line twice do you have an idea how we could solve that?

Maybe we can run a regex and just ignore comment lines?

@Jeehut
Copy link
Contributor

Jeehut commented Jun 22, 2019

Hm? That shouldn't happen, see this line.

@fredpi
Copy link
Contributor

fredpi commented Nov 15, 2019

@mrylmz Any progress here? ;)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants