Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding 'Don't show again' button to ef core tools warning, resolves #213 #216

Open
wants to merge 58 commits into
base: main
Choose a base branch
from
Open

Adding 'Don't show again' button to ef core tools warning, resolves #213 #216

wants to merge 58 commits into from

Conversation

Nepp3r
Copy link

@Nepp3r Nepp3r commented Mar 27, 2024

No description provided.

seclerp
seclerp requested changes Mar 27, 2024
View reviewed changes
Copy link
Member

@seclerp seclerp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, thanks for the contribution! Overall it's good for me, but please take a look at minor things in comments.

...otlin/com/jetbrains/rider/plugins/efcore/features/eftools/SuppressEfCoreToolsInstallation.kt Outdated Show resolved Hide resolved
src/rider/main/kotlin/com/jetbrains/rider/plugins/efcore/startup/EfCoreStartupListener.kt Outdated Show resolved Hide resolved
src/rider/main/kotlin/com/jetbrains/rider/plugins/efcore/state/CommonOptionsStateService.kt Outdated Show resolved Hide resolved
src/rider/main/resources/messages/EfCoreUiBundle.properties Outdated Show resolved Hide resolved
Nepp3r and others added 3 commits March 28, 2024 20:25
@Nepp3r @seclerp
Update src/rider/main/kotlin/com/jetbrains/rider/plugins/efcore/featu…
00b5308 
…res/eftools/SuppressEfCoreToolsInstallation.kt

Co-authored-by: Andrii Rublov <seclerp.dev@gmail.com>
@Nepp3r @seclerp
Update src/rider/main/kotlin/com/jetbrains/rider/plugins/efcore/start…
174a571 
…up/EfCoreStartupListener.kt

Co-authored-by: Andrii Rublov <seclerp.dev@gmail.com>
@Nepp3r
Change get/set functions with field and removing unnecessary description
060bdea
Nepp3r and others added 15 commits March 28, 2024 21:23
@Nepp3r @seclerp
Update src/rider/main/kotlin/com/jetbrains/rider/plugins/efcore/state…
7d3d6ae 
…/CommonOptionsStateService.kt

Co-authored-by: Andrii Rublov <seclerp.dev@gmail.com>
@Nepp3r @seclerp
Update src/rider/main/kotlin/com/jetbrains/rider/plugins/efcore/state…
5bc3079 
…/CommonOptionsStateService.kt

Co-authored-by: Andrii Rublov <seclerp.dev@gmail.com>
@Nepp3r @seclerp
Update src/rider/main/kotlin/com/jetbrains/rider/plugins/efcore/featu…
c669795 
…res/eftools/SuppressEfCoreToolsInstallation.kt

Co-authored-by: Andrii Rublov <seclerp.dev@gmail.com>
@Nepp3r
Fix typo
0ed0b5d
@denis417 @intellij-monorepo-bot
Use Product.Root file as an indication that we are in the internal build
eda611a 
GitOrigin-RevId: 334c005cbeb916ccdb8598bd61f08fc23170d0da
@intellij-monorepo-bot
[RIDER] Change update thread for actions related on project model inf…
6d669f8 
…ormation from dataContext

GitOrigin-RevId: 392ac43d59b3da35a10835677e9642db376ff601
@mfilippov @intellij-monorepo-bot
migrate rider-efcore to new rdgen approach
a9f347a 
GitOrigin-RevId: 97967dccb602ee711c5418e251b17863f2d83d9c
@mfilippov @intellij-monorepo-bot
fix .gitignore and cleanup
80aef57 
GitOrigin-RevId: fddeaad6fe1bb1a64ffa4f669aa31cd8bb39056c
@mfilippov @intellij-monorepo-bot
cleanup fotTea plugin
9fe352e 
GitOrigin-RevId: 9903f1b73af81c86ef033e833a0238e420c806ce
@mfilippov @intellij-monorepo-bot
unify efcore plugin settings
09aad3a 
GitOrigin-RevId: 6e725a5a34b98dfd76a005af7c0a99a22f96a164
@ForNeVeR @intellij-monorepo-bot
Rider EFCore plugin: move the generated sources
ea5a723 
GitOrigin-RevId: 6497993234a86cf5bbf1deef8b95e308deaf3062
@ForNeVeR @intellij-monorepo-bot
Rider EFCore plugin: new way of detecting internal builds
ca2baa4 
GitOrigin-RevId: 56fc10c1a588ed500ceeee7a2b1bbdf4a0a45691
@ForNeVeR @intellij-monorepo-bot
Rider EFCore plugin: migrate to IntelliJ Platform Gradle Plugin v2
ba7321a 
GitOrigin-RevId: 5214d2ca0eeba5d0935ab63d9be9f13aed93db21
@dmimat @intellij-monorepo-bot
[dotnet] Update help topic IDs
21558e6 
GitOrigin-RevId: eac047b28146e18f1970ba665b6243ec1a0ff63b
@seclerp @intellij-monorepo-bot
[nuget]: Bump NuGet libs version
5e40749 
GitOrigin-RevId: a20ac80375574a02de9da478f8ba717c821fb99a
@Nepp3r Nepp3r requested a review from seclerp May 19, 2024 16:33
seclerp
seclerp requested changes May 19, 2024
View reviewed changes
Copy link
Member

@seclerp seclerp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall it looks good, thanks! Only the one little issue left

src/rider/main/kotlin/com/jetbrains/rider/plugins/efcore/startup/EfCoreStartupListener.kt Outdated Show resolved Hide resolved
@Nepp3r @seclerp
Update src/rider/main/kotlin/com/jetbrains/rider/plugins/efcore/start…
4921917 
…up/EfCoreStartupListener.kt

Co-authored-by: Andrii Rublov <seclerp.dev@gmail.com>
@Nepp3r
Copy link
Author

Nepp3r commented May 20, 2024

Thanks for the review! I've commited requested changes

@Nepp3r Nepp3r requested a review from seclerp May 20, 2024 16:28
develar and others added 3 commits May 21, 2024 17:41
@develar @seclerp
IJPL-149476 remove unneeded and not correct "<idea-version since-buil…
af3dfa3 
…d="_PLACEHOLDER_" />"

GitOrigin-RevId: 903817ebc27f13c10dc6c8df78c3d7375eab0a78
@ForNeVeR @seclerp
Rider EFCore Plugin: fix plugin.xml inspections
8bf799d 
GitOrigin-RevId: c00a865567ddd4ebb94aaa234c97a42e9dd88c0c
@ForNeVeR @seclerp
Rider EFCore: enable JBR for OSS builds
4b6a828 
GitOrigin-RevId: d7702d00a64cfa3a53ce5171eb5d8e74e7568828
Ilia Kirianovskii and others added 30 commits June 27, 2024 01:43
@seclerp
Bump constants to 243
bd3a883 
# Conflicts:
# 	rider/ide/resources/idea/RiderApplicationInfo.xml

GitOrigin-RevId: 839e4fd7eca086979a595b1def0712e6cf8685db
@seclerp
[ef-core]: Fix incorrect service retrieval for JsonSerializer
07ce676
@mfilippov @seclerp
Cleanup PropertyGroup elements in project files
a55afa6 
GitOrigin-RevId: be17d071edcb357dc940da538570cf2c0342c490
@ForNeVeR @seclerp
rider-efcore: migrate to IntelliJ Platform Gradle Plugin v2 beta 8
d8b3c8b 
GitOrigin-RevId: 61ab4902a06f86eccd4bd83e802229a508ba02c0
@ForNeVeR @seclerp
rider-efcore: Gradle cleanup
726d8d4 
GitOrigin-RevId: 73cbb66c07d9f2c79ff4a24ccc72c8d8539cce49
@Iliya-usov @seclerp
Update rd
e3b75f5 
GitOrigin-RevId: 27857aed6054c3da58ef8cc51993f9d69ada0651
@Rizzen @seclerp
NuGet 6.9.20240506.130 -> 6.10.20240726.136
7ae507a 
GitOrigin-RevId: a8af2ee0e8781400ef545dcfaa26f84a80a3a0ab
@seclerp
[ef-core]: Fix RIDER-112371: Relax rules for appsettings.json and `…
4ffae4f 
…secrets.json` parsing, allow trailing commas
@seclerp
[dotnet] obsolete default ctor of SolutionComponentAttribute
975a723 
GitOrigin-RevId: 4b6208f49f9f3601a13497525aa80f51a5c791f1
@gregsh @seclerp
migrate ActionPlaces.isPopupPlace usages
21f5726 
GitOrigin-RevId: 6caf1344423c8142a549d507c19e4ea40a721284
@gregsh @seclerp
drop ActionPlaces.isMainToolbar usages
6149860 
GitOrigin-RevId: 071f16160dc8b9cea9bd1b85bd15e7fb8ea91061
@trespasserw @seclerp
[project] pruning FileChooserDescriptor overrides (IJPL-150176 prer…
a8e866f 
…equisite)

`BrowseFolderRunnable` and `*WithBrowseButton` family: getting rid of separate "title" and "description" parameters in favor of the chooser descriptor object, to avoid cloning the latter down the road.

GitOrigin-RevId: 33ec5968a1db953c60848974135055c288accf85
@Rizzen @seclerp
autofix
5d29f17 
GitOrigin-RevId: 7d8ae94e4cd47d7d5a78c5654d3a577d305d5877
@develar @seclerp
IJ-CR-146078 extract intellij.platform.bootstrap
5af946d 
GitOrigin-RevId: b79efc92829111228e83058e54381d8e02116b6f
@seclerp
Upgrade JetBrains.NuGet.* to v6.12.20241007.141 (NP-1760)
3e40c23 
GitOrigin-RevId: acb6f7201ee7f8c92e7d8485fa80ae5fb51a4fab
@Rizzen @seclerp
Bump NuGet.Client 6.12.20241007.141 -> 6.12.20241010.144
dda3d82 
GitOrigin-RevId: 5af1bffbb2e90af41248754da4344a7ce1c55215
@ForNeVeR @seclerp
.NET: update Rd to 2024.3.0
f05004f 
GitOrigin-RevId: 69ad6f8c300a593df89d105deb052058ecfef65a
@seclerp
Remove obsolete marketplace badge from the README
1fb1020
@seclerp
Bump constants to 251
fe794a9 
# Conflicts:
# 	rider/ide/resources/idea/RiderApplicationInfo.xml

GitOrigin-RevId: 25ee62e33bb1a8ea36920c47b6c7ecca842b8287
@seclerp
[efcore]: Fix RIDER-118684: Support .NET 9 projects
a155d33 
GitOrigin-RevId: c13148c738013ab541f39991d1dfb5c7713f795a
@Nepp3r
Adding 'Don't show again' button to ef core tools warning, resolves J…
4ce98e2 
…etBrains#213
@Nepp3r @seclerp
Update src/rider/main/kotlin/com/jetbrains/rider/plugins/efcore/featu…
b39956c 
…res/eftools/SuppressEfCoreToolsInstallation.kt

Co-authored-by: Andrii Rublov <seclerp.dev@gmail.com>
@Nepp3r @seclerp
Update src/rider/main/kotlin/com/jetbrains/rider/plugins/efcore/start…
1ff4e9a 
…up/EfCoreStartupListener.kt

Co-authored-by: Andrii Rublov <seclerp.dev@gmail.com>
@Nepp3r
Change get/set functions with field and removing unnecessary description
fab6d52
@Nepp3r @seclerp
Update src/rider/main/kotlin/com/jetbrains/rider/plugins/efcore/state…
02f1a16 
…/CommonOptionsStateService.kt

Co-authored-by: Andrii Rublov <seclerp.dev@gmail.com>
@Nepp3r @seclerp
Update src/rider/main/kotlin/com/jetbrains/rider/plugins/efcore/state…
7f3871d 
…/CommonOptionsStateService.kt

Co-authored-by: Andrii Rublov <seclerp.dev@gmail.com>
@Nepp3r @seclerp
Update src/rider/main/kotlin/com/jetbrains/rider/plugins/efcore/featu…
32d712b 
…res/eftools/SuppressEfCoreToolsInstallation.kt

Co-authored-by: Andrii Rublov <seclerp.dev@gmail.com>
@Nepp3r
Fix typo
c6a4307
@Nepp3r @seclerp
Update src/rider/main/kotlin/com/jetbrains/rider/plugins/efcore/start…
28bd964 
…up/EfCoreStartupListener.kt

Co-authored-by: Andrii Rublov <seclerp.dev@gmail.com>
@Nepp3r
Merge branch 'DisEfCoreToolsNot' of github.com:Nepp3r/rider-efcore in…
2dc2998 
…to DisEfCoreToolsNot
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seclerp seclerp seclerp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.