Skip to content

Commit

Permalink
Fix/renovate pipeline (elastic#204672)
Browse files Browse the repository at this point in the history
## Summary

Renovate pipeline isn't being uploaded to Buildkite properly and `pre`
and `post` build steps were not necessary and create errors with CI
stats.

[Successful CI
run](https://buildkite.com/elastic/kibana-pull-request/builds/261627)
  • Loading branch information
Ikuni17 authored and JoseLuisGJ committed Dec 19, 2024
1 parent c25c30a commit 3119345
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 11 deletions.
8 changes: 0 additions & 8 deletions .buildkite/pipelines/pull_request/renovate.yml
Original file line number Diff line number Diff line change
@@ -1,12 +1,4 @@
steps:
- command: .buildkite/scripts/lifecycle/pre_build.sh
label: Pre-Build
timeout_in_minutes: 10
agents:
machineType: n2-standard-2

- wait

- command: .buildkite/scripts/steps/renovate.sh
label: 'Renovate validation'
agents:
Expand Down
7 changes: 4 additions & 3 deletions .buildkite/scripts/pipelines/pull_request/pipeline.ts
Original file line number Diff line number Diff line change
Expand Up @@ -39,15 +39,16 @@ const getPipeline = (filename: string, removeSteps = true) => {
return;
}

pipeline.push(getAgentImageConfig({ returnYaml: true }));

const onlyRunQuickChecks = await areChangesSkippable([/^renovate\.json$/], REQUIRED_PATHS);
if (onlyRunQuickChecks) {
pipeline.push(getPipeline('.buildkite/pipelines/pull_request/renovate.yml', false));
pipeline.push(getPipeline('.buildkite/pipelines/pull_request/post_build.yml'));
console.log('Isolated changes to renovate.json. Skipping main PR pipeline.');

console.log([...new Set(pipeline)].join('\n'));
return;
}

pipeline.push(getAgentImageConfig({ returnYaml: true }));
pipeline.push(getPipeline('.buildkite/pipelines/pull_request/base.yml', false));

if (await doAnyChangesMatch([/^packages\/kbn-handlebars/])) {
Expand Down

0 comments on commit 3119345

Please sign in to comment.