Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make GPUInterpreter extensible #634

Draft
wants to merge 1 commit into
base: vc/plugins
Choose a base branch
from

Conversation

vchuravy
Copy link
Member

Currently Enzyme uses it's own AbstractInterpreter, in particular to
handle inlining blocking of functions with custom rules and to handle
nested autodiff operations.

  • Create a version of Enzyme with this
  • Support a version of gpuc.deferred(meta)

Copy link
Member Author

vchuravy commented Sep 26, 2024

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @vchuravy and the rest of your teammates on Graphite Graphite

Copy link

codecov bot commented Sep 26, 2024

Codecov Report

Attention: Patch coverage is 84.16667% with 19 lines in your changes missing coverage. Please review.

Project coverage is 72.29%. Comparing base (9b54632) to head (1638cc2).

Files with missing lines Patch % Lines
src/jlgen.jl 79.12% 19 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff               @@
##           vc/plugins     #634      +/-   ##
==============================================
- Coverage       73.68%   72.29%   -1.40%     
==============================================
  Files              24       24              
  Lines            3310     3353      +43     
==============================================
- Hits             2439     2424      -15     
- Misses            871      929      +58     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vchuravy vchuravy force-pushed the 09-26-make_gpuinterpreter_extensible branch 2 times, most recently from 4e127d6 to 6f8532b Compare September 27, 2024 13:47
@vchuravy vchuravy force-pushed the 09-26-make_gpuinterpreter_extensible branch 5 times, most recently from 9af6e00 to 9fa52ca Compare September 27, 2024 18:23
@vchuravy vchuravy force-pushed the 09-26-make_gpuinterpreter_extensible branch from 9fa52ca to 052a118 Compare October 2, 2024 08:48
@vchuravy vchuravy mentioned this pull request Oct 2, 2024
@vchuravy vchuravy marked this pull request as ready for review October 2, 2024 09:29
@vchuravy vchuravy marked this pull request as draft October 2, 2024 09:30
@vchuravy vchuravy force-pushed the 09-26-make_gpuinterpreter_extensible branch from 052a118 to 4ef6019 Compare October 3, 2024 10:27
Currently Enzyme uses it's own AbstractInterpreter, in particular to
handle inlining blocking of functions with custom rules and to handle
nested autodiff operations.

- [ ] Create a version of Enzyme with this
- [ ] Support a version of `gpuc.deferred(meta)`
@vchuravy vchuravy force-pushed the 09-26-make_gpuinterpreter_extensible branch from 4ef6019 to 1638cc2 Compare October 4, 2024 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant