Rename functions with is_
consistently
#3627
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This library seems to have the convention that a function name is x is written
isx
if x is one word, andis_y_z
if x is at least two words y z. The exception is if z istype
, as inisboundedtype
, since this is a modification ofisbounded
and adding the underscores would obscure that connection.The renamings done here are:
is_polyhedral
→ispolyhedral
is_hyperplanar
→ishyperplanar
_is_hyperplane
→_ishyperplanar
_is_halfspace
→_ishalfspace
_is_linearcombination
→_is_linear_combination
Of these, 1. and 2. are breaking changes. The other three functions are internal. 3. also renames
plane
->planar
to be closer to the API function.There are two more API functions starting with
is_
:is_intersection_empty
andis_interior_point
. As described above, they fall in the second pattern, so I kept their names. (One can consider renamingis_interior_point
closer toin
, for instance toin_interior
.)