Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AbstractHyperrectangle: let difference return results of different types #3676

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

AbstractHyperrectangle: let difference return results of different types #3676

wants to merge 1 commit into from

Conversation

schillic
Copy link
Member

@schillic schillic commented Dec 15, 2024 •
edited
Loading

This is an optional PR. It arguably makes the result easier to understand if empty, but since it leads to type instability, I am not sure about it.

EDIT: Here is one argument for not changing: the implementation of ⊆ relies on the result always being a UnionSetArray.

@schillic schillic added the discussion 🗣️ Requires human input label Dec 15, 2024
@schillic schillic marked this pull request as ready for review December 15, 2024 22:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
discussion 🗣️ Requires human input
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@schillic