Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhance ranking code #589

Merged
merged 7 commits into from
Feb 1, 2021
Merged

Enhance ranking code #589

merged 7 commits into from
Feb 1, 2021

Commits on Aug 9, 2020

  1. ordinalrank!(): use eachindex()

    @alyst
    alyst committed Aug 9, 2020
    Configuration menu
    Copy the full SHA
    ef2ba05 View commit details
    Browse the repository at this point in the history

  2. ranking: use _rank() helper, @inbounds 

    _rank() helper provides:
1) correct support for n-dim, n>1, input arrays
2) minimizes code duplication
3) passthrough of sortperm() args
4) macro-less support for missing values
    @alyst
    alyst committed Aug 9, 2020
    Configuration menu
    Copy the full SHA
    3848eff View commit details
    Browse the repository at this point in the history

Commits on Oct 2, 2020

  1. revert to disallowmissing()

    @alyst
    alyst committed Oct 2, 2020
    Configuration menu
    Copy the full SHA
    d050fdb View commit details
    Browse the repository at this point in the history

  2. replace while-loops with for-loops

    @alyst
    alyst committed Oct 2, 2020
    Configuration menu
    Copy the full SHA
    8a296ba View commit details
    Browse the repository at this point in the history

  3. rankings: expand sortkwargs in docstring

    @alyst
    alyst committed Oct 2, 2020
    Configuration menu
    Copy the full SHA
    831a0e5 View commit details
    Browse the repository at this point in the history

  4. rankings: cleanup docstring

    @alyst
    alyst committed Oct 2, 2020
    Configuration menu
    Copy the full SHA
    88aeee5 View commit details
    Browse the repository at this point in the history

Commits on Oct 6, 2020

  1. remove unused

    @alyst
    alyst committed Oct 6, 2020
    Configuration menu
    Copy the full SHA
    c842c07 View commit details
    Browse the repository at this point in the history