-
Notifications
You must be signed in to change notification settings - Fork 5
Conversation
src/steps/cron-jobs/index.ts
Outdated
IntegrationStep, | ||
RelationshipClass, | ||
} from '@jupiterone/integration-sdk-core'; | ||
import * as k8s from '@kubernetes/client-node'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we try to import only relevant functions ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
imported only relevant
src/steps/daemon-sets/index.ts
Outdated
IntegrationStep, | ||
RelationshipClass, | ||
} from '@jupiterone/integration-sdk-core'; | ||
import * as k8s from '@kubernetes/client-node'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same as previous
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
imported only relevant
], | ||
}); | ||
}); | ||
}, 500000); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why this hardcoded value? Can we move it to constants?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
removed as not needed
package.json
Outdated
@@ -38,9 +38,10 @@ | |||
"dependencies": { | |||
"@jupiterone/integration-sdk-dev-tools": "^8.22.6", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please update all packages to latest version. Check the armis for reference
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
updated to latest
|
Findings | ||||||||||||||||||||||||||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Dependency: npm / hawk@ 3.1.3 Vulnerability Information
|
||||||||||||||||||||||||||||||||||||||||
Dependency Location https://github.com/JupiterOne/graph-kubernetes/blob/d83571bcb4aaa5859e254eb4a100aabea59ed787/yarn.lock |
||||||||||||||||||||||||||||||||||||||||
Dependency: npm / hoek@ 2.16.3 Vulnerability Information
|
||||||||||||||||||||||||||||||||||||||||
Dependency Location https://github.com/JupiterOne/graph-kubernetes/blob/d83571bcb4aaa5859e254eb4a100aabea59ed787/yarn.lock |
||||||||||||||||||||||||||||||||||||||||
Dependency: npm / npm@ 2.15.12 Vulnerability Information
|
||||||||||||||||||||||||||||||||||||||||
Dependency Location https://github.com/JupiterOne/graph-kubernetes/blob/d83571bcb4aaa5859e254eb4a100aabea59ed787/yarn.lock |
||||||||||||||||||||||||||||||||||||||||
Dependency: npm / npm-user-validate@ 0.1.5 Vulnerability Information
|
||||||||||||||||||||||||||||||||||||||||
Dependency Location https://github.com/JupiterOne/graph-kubernetes/blob/d83571bcb4aaa5859e254eb4a100aabea59ed787/yarn.lock |
||||||||||||||||||||||||||||||||||||||||
Dependency: npm / tar@ 2.2.2 Vulnerability Information
|
||||||||||||||||||||||||||||||||||||||||
Dependency Location https://github.com/JupiterOne/graph-kubernetes/blob/d83571bcb4aaa5859e254eb4a100aabea59ed787/yarn.lock |
Not a finding? Ignore it by adding a comment on the line with just the word noboost
.
Scanner: boostsecurity - BoostSecurity osv-scanner
No description provided.