Merge pull request #187 from JupiterOne/INT-4292-fixLastSeen

make asset firstSeen lastSeen human-readable
JupiterOne · Aug 5, 2022 · f059f48 · f059f48
2 parents 901bd4a + f11171a
commit f059f48
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 15 deletions.
diff --git a/.github/workflows/gitleaks.yml b/.github/workflows/gitleaks.yml
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -8,6 +8,8 @@ and this project adheres to
 
 ## [Unreleased]
 
+- fix tenable_asset `firstSeen` and `lastSeen` properties to be human-readable
+
 ## [8.5.0] 2022-06-08
 
 - move @jupiterone/tenable-client-nodejs to this repo

diff --git a/src/steps/vulnerabilities/converters.ts b/src/steps/vulnerabilities/converters.ts
@@ -51,6 +51,7 @@ export function createAssetEntity(
   } catch (err) {
     logger.warn({ err }, 'Encountered error when checking entity size');
   }
+
   return createIntegrationEntity({
     entityData: {
       source: data,
@@ -72,8 +73,8 @@ export function createAssetEntity(
         terminatedBy: data.terminated_by,
         updatedAt: parseTimePropertyValue(data.updated_at),
         deletedAt: parseTimePropertyValue(data.deleted_at),
-        firstSeen: parseTimePropertyValue(data.first_seen),
-        lastSeen: parseTimePropertyValue(data.last_seen),
+        firstSeenOn: parseTimePropertyValue(data.first_seen),
+        lastSeenOn: parseTimePropertyValue(data.last_seen),
         firstScanTime: parseTimePropertyValue(data.first_scan_time),
         lastScanTime: parseTimePropertyValue(data.last_scan_time),
         lastAuthenticatedScanDate: parseTimePropertyValue(