Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Memgraph support #99

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

matea16
Copy link

@matea16 matea16 commented Aug 4, 2023

Hi, I'm Matea, Memgraph's Developer Experience team member.
Recently I've been deep diving into your amazing Starbase project and decided to enhance its compatibility with Memgraph. I adjusted a few files and queries in order for them to work with Memgraph, and ensured seamless integration.

I've also taken the initiative to create a pull request for the integration of Memgraph's SDK CLI for full compatibility.
Looking forward to your feedback!

@matea16 matea16 requested a review from a team as a code owner August 4, 2023 08:02
@matea16 matea16 requested a review from a team August 4, 2023 08:02
@@ -16,6 +16,14 @@ integrations:
config:
AUTH_TOKEN: example-token
ORGANIZATION_SLUG: example-organization
storage:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know this is just an example file, but we technically can't have two storage entries in a valid config file. I'd recommend creating a separate example file for showing a Memgraph configuration.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I created another config.yaml.memgraph.example, the name might be too long and I can change it if necessary

config:
username:
password:
uri: bolt://localhost:3000
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is port 3000 listed here the default port for uploading data to Memgraph? I'm by no means an expert at Memgraph, but I was under the impression that like Neo4j it uses port 7687 for the bolt connection to upload data.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are completely right, Memgraph uses the same port. Memgraph Lab has 3000 for the visualization part so this was a bit of a "tip-feller" from my side

- '7444:7444'
- '7687:7687'
volumes:
- mg_lib:/var/lib/memgraph
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are these the correct volume paths? It looks like you added docker/.memgraph to the .gitignore file, but these all look like they'll be in individual folders and not within a .memgraph folder.

@adam-in-ict
Copy link
Contributor

Thanks so much for the contribution!

I'm assuming based on my initial look at the PR that we'll want to complete the SDK contribution first to expose the additional memgraph commands, but I went ahead and put in a few small comments here. I'll go have a look at the SDK PR here shortly.

Thanks!

@matea16
Copy link
Author

matea16 commented Sep 21, 2023

So sorry for the late response. I've added another commit where I agree with your comments and fixed stuff mentioned. Feel free to let me know if there's something else you noticed, thank you! I'll also get to the sdk PR asap :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants