Convert AddressPage.js to TSX. #346
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
toolness
commented
Jul 28, 2020
Comment on lines
14
to
31
| type Addr = { | ||
| housenumber: string; | ||
| streetname: string; | ||
| zip: string; | ||
| boro: string; | ||
| bbl: string; | ||
| yearbuilt: number; | ||
| unitsres: number; | ||
| rsunits2007: number; | ||
| rsunits2017: number; | ||
| openviolations: number; | ||
| totalviolations: number; | ||
| evictions: string | null; | ||
| ownernames: { title: string; value: string }[]; | ||
| lastsaledate: string; | ||
| lastsaleamount: string; | ||
| lastsaleacrisid: string; | ||
| }; |
There was a problem hiding this comment.
Well, at least we're getting rid of this duplicate typing.
toolness
commented
Jul 28, 2020
| super(props); | ||
|
|
||
| this.state = { | ||
| searchAddress: { ...props.match.params }, // maybe this should be | ||
| userAddr: {}, // merged together? | ||
| hasSearched: false, | ||
| geosearch: {}, |
There was a problem hiding this comment.
I'm a bit queasy about this change but hopefully it should work. We should probably kick the tires a bit just to make sure nothing explodes...
added 10 commits
July 28, 2020 14:17
|
@toolness this is ready for your eyes again! |
toolness
changed the title
|
awesome thanks @sraby ! |
sraby
pushed a commit
that referenced
this pull request
Jul 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This converts
AddressPage.jsto TSX.Crucially, though, most of the address-related state fields are typed toany, which makes some of this incomplete. Those fields are going to take a lot of work to properly type because of how they're being used, and how they interact with some components further down in the component hierarchy (some of which are still untyped). It might ultimately be easier to just refactor the data model to be more comprehensible, rather than attempting to add types as-is.Note that this introduces an explicit
throwfor the situation where an address search has no geosearch information; this essentially means that the error signature for #340 will now be different, as it will be an explicit exception rather thanCannot get property 'bbl' of undefined or null.