Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update DatadogObjc dependency to v2.16.0 #77

Draft
wants to merge 8 commits into
base: main
Choose a base branch
from
Draft

Update DatadogObjc dependency to v2.16.0 #77

wants to merge 8 commits into from

Conversation

twyatt
Copy link
Member

@twyatt twyatt commented Jul 2, 2024 •
edited
Loading

Important

Bumped iOS deployment target to 12 (from 11) to satisfy upstream target bump.

@twyatt twyatt added the maintenance General maintenance that doesn't effect the public API. label Jul 2, 2024
@twyatt
Copy link
Member Author

twyatt commented Jul 3, 2024 •
edited
Loading

Currently failing with:

> Task :bundled:podBuildDatadogObjcIphoneos
Error: Exception in thread "main" java.lang.IllegalArgumentException: 'DDRUMErrorEventErrorMeta' is going to be declared twice
	at org.jetbrains.kotlin.native.interop.gen.KotlinFile.<init>(KotlinCodeModel.kt:261)
	at org.jetbrains.kotlin.native.interop.gen.StubIrBridgeBuilder$kotlinFile$1.<init>(StubIrBridgeBuilder.kt:44)
	at org.jetbrains.kotlin.native.interop.gen.StubIrBridgeBuilder.<init>(StubIrBridgeBuilder.kt:44)
	at org.jetbrains.kotlin.native.interop.gen.StubIrDriver.run(StubIrDriver.kt:154)
	at org.jetbrains.kotlin.native.interop.gen.jvm.MainKt.processCLib(main.kt:368)
	at org.jetbrains.kotlin.native.interop.gen.jvm.MainKt.processCLibSafe(main.kt:247)
	at org.jetbrains.kotlin.native.interop.gen.jvm.MainKt.access$processCLibSafe(main.kt:1)
	at org.jetbrains.kotlin.native.interop.gen.jvm.Interop.interop(main.kt:105)
	at org.jetbrains.kotlin.cli.utilities.InteropCompilerKt.invokeInterop(InteropCompiler.kt:49)
	at org.jetbrains.kotlin.cli.utilities.MainKt.mainImpl(main.kt:23)
	at org.jetbrains.kotlin.cli.utilities.MainKt.main(main.kt:44)

Related upstream issues:

@twyatt twyatt force-pushed the twyatt/datadog-objc branch 3 times, most recently from e4569b7 to 41ed4c6 Compare July 3, 2024 22:08
@twyatt twyatt mentioned this pull request Jul 6, 2024
Merged
@twyatt
Copy link
Member Author

twyatt commented Jul 6, 2024

Workaround linked in #77 (comment) worked for DDRUMErrorEventErrorMeta, but does not seem to work for char16_t:

Error: Exception in thread "main" java.lang.IllegalArgumentException: 'char16_tVar' is going to be declared twice
	at org.jetbrains.kotlin.native.interop.gen.KotlinFile.<init>(KotlinCodeModel.kt:261)
	at org.jetbrains.kotlin.native.interop.gen.StubIrBridgeBuilder$kotlinFile$1.<init>(StubIrBridgeBuilder.kt:44)
	at org.jetbrains.kotlin.native.interop.gen.StubIrBridgeBuilder.<init>(StubIrBridgeBuilder.kt:44)
	at org.jetbrains.kotlin.native.interop.gen.StubIrDriver.run(StubIrDriver.kt:154)
	at org.jetbrains.kotlin.native.interop.gen.jvm.MainKt.processCLib(main.kt:368)
	at org.jetbrains.kotlin.native.interop.gen.jvm.MainKt.processCLibSafe(main.kt:247)
	at org.jetbrains.kotlin.native.interop.gen.jvm.MainKt.access$processCLibSafe(main.kt:1)
	at org.jetbrains.kotlin.native.interop.gen.jvm.Interop.interop(main.kt:105)
	at org.jetbrains.kotlin.cli.utilities.InteropCompilerKt.invokeInterop(InteropCompiler.kt:49)
	at org.jetbrains.kotlin.cli.utilities.MainKt.mainImpl(main.kt:23)
	at org.jetbrains.kotlin.cli.utilities.MainKt.main(main.kt:44)

@twyatt twyatt changed the title Update DatadogObjc dependency to v2.13.0 Update DatadogObjc dependency to v2.16.0 Aug 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
maintenance General maintenance that doesn't effect the public API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@twyatt