-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/integrating b solver #118
Feature/integrating b solver #118
Conversation
Update to Kassiopeia 3.2
…module of something else
…al and checking mixing in Locust MC.
…ia from Locust. The conditions are presently global and are defined in small functions that can be dropped into the appropriate static event modifier class. Modified classes are LMCKassSignalGenerator and KSRoot.
…tronRadiationExtractor::ExecutePostStepModification().
…tart of each Kass event.
…n thread status out of ReceivedEventStartCondition.
… KSTrajInterpolatorHermite.cxx pending more testing.
update to Kassiopeia 3.3.2
Feature/eventmod
Revert "Feature/eventmod"
Update to Kassiopeia 3.5
update to Kassiopeia 3.6.1
Check for Boost library as variable or imported target
Kassiopeia v3.7
Merge Kassiopeia v3.7.4
Updates with examples
Build fixes on Docker
Update to v3.7.7
Kassiopeia v3.8.0
…ptop after upgrading Root version to > 6.16
…kasper_use_vtk=false.
… With vtk v9.1 the build works.
feature/v3.8.0
Kassiopeia v3.8.2
synchronize main branch
Update main branch
Hi @pslocum, thanks for your message. Unfortunately, we get a 404 error for your config that you provided via the link. It would be great if you could fix this so that we can have a look. |
Hi @richard Salomon ***@***.***>, apologies for the 404. The
config files have now been placed here
<https://github.com/pslocum/configFiles.git>.
…On Tue, Oct 1, 2024 at 3:02 AM Richard S ***@***.***> wrote:
Hi @pslocum <https://github.com/pslocum>, thanks for your message.
Unfortunately, we get a 404 error for your config that you provided via the
link. It would be great if you could fix this so that we can have a look.
—
Reply to this email directly, view it on GitHub
<#118 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABVBROLKW5JHMDHZOQYUXZLZZJCI3AVCNFSM6AAAAABPEQZVW6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGOBUHE2TKNZYHE>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Hi @pslocum, thanks for identifying this. It seems that the rod_space is added 3 times to the electromagnet container instead of just once. I am not sure at the moment, why that is the case, but your workaround is probably only applicable to the specific case where you have only one geometry element for the field calculation. I need to investigate further what happens when the container is created. Will keep you updated! |
Hi @richeldichel, thanks for the update. And please keep me posted with any additional steps or checks that would be useful. |
I think I have found the culprit! In line 46 of your config
Here you define the spaces to be used via To make this mistake more visible, I will create a PR that adds a warning when a tag is encountered in a place where a path is expected. |
Hi @richeldichel, thank you very much for identifying this. And yes, as you point out, it will be helpful to have a warning when the full geometry path is needed instead of just the tag. Thanks again! |
Closing this in favor of #119 |
Following a brief test with a single off-center finite wire segment defined by 2 points, I am noticing that the B-field is being calculated 3 times using Biot-Savart, and is being accumulated. This causes the output B fields to be too high by 3x. I am suggesting a possible workaround such that the accumulation is removed. However, there may be a better way to think about this. The config files that I am using are here. Thanks in advance for any thoughts.