Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dev #12

Open
wants to merge 73 commits into
base: master
Choose a base branch
from
Open

Dev #12

wants to merge 73 commits into from

Conversation

hsonne
Copy link
Member

@hsonne hsonne commented Aug 6, 2023 •
edited by mrustl
Loading

This change is Reviewable

hsonne and others added 30 commits July 15, 2023 08:08
@hsonne
No need for createDirectory(), unify url defs.
5c26f4e
@hsonne
Improve readability of DESCRIPTION file
638efe9
@hsonne
Rename placeholder (was duplicated)
9bf6126
@hsonne
Generalise download of scripts from GitHub
e86d363
@hsonne
Use pipe operator (call usetthis::use_pipe())
6a62d44
@hsonne
Improve comment
8630a96
@hsonne
Use the pipe operator
24332e3
Use the pipe operator
e913c4b
@hsonne
Simplify the argument lists
4354196
@hsonne
Use the pipe operator
afc2ee4
@hsonne
Add get_function_assignments(),
b289efc 
moved from kwb.test, including the test
@hsonne
Improve duplicatesToFiles()
13a08d8 
- Create fun_duplicates if not given
- Call the function for each unique function
  name if no function name is given
@hsonne
Extract get_info_on_duplicated_function_names()
c98c135
@hsonne
Add comments, simplify, use stopFormatted()
34c5e88
@hsonne
Loop through unique contents instead of while()
f3cdc4b
@hsonne
Extract found_in_scripts_header()
d421056
@hsonne
Improve naming, use lapply() instead of for()
4d9d987
@hsonne
Simplify/unify writeContentsTo(Less)Files()
9c6e1a9
@hsonne
Add utility function cat_formatted()
7086243
@hsonne
Add package specifiers, return file paths
1cc0801
@hsonne
Suppress warnings, error outputs in type_info()
fbd1386
@hsonne
Extract cat_error(), use startsWith()
7743c1d 
and do not exclude "is."-functions
@hsonne
Return vector of file paths, improve file names
10e0109
@hsonne
Fix tests
3038c4e
@hsonne
Use helper function collapse()
12a49ae 
and simplify by calling commaCollapse() in any
case (even if there is only one element)
@hsonne
Remove empty documentation of return value
eb5fd52
@hsonne
Refactor get_elements_by_type(), use pipe
ae555bf 
and utility function remove_first_and_last_slash()
@hsonne
Move functions from main.R to scripts per function
42c1ea6
@hsonne
Fix error in info_to_text(), do not use sprintf()
4689c2d
@hsonne
Check for list-like structure, not for list
8ab6eaf
hsonne and others added 30 commits April 4, 2024 14:47
@hsonne
Improve readability, use variable "keep_row"
562d1b2
@hsonne
Fix error in example. Add "keep.source = TRUE"
6d269a2
@hsonne
Use deparse() to make ensure that "text" is chr
054c860
@hsonne
Add stop_formatted(), warn_formatted()
8478c64
@hsonne
Add message_formatted()
ff8718d
@hsonne
Use cat_formatted()
06772d0
@hsonne
Add shortcut to kwb.utils::shorten()
90444b7
@hsonne
Add shortcuts to select(Column|Element)s()
ae79444 
in kwb.utils
@hsonne
Add shortcuts to kwb.utils::catAndRun()
afd7458
@hsonne
Add shortcuts to kwb.utils::catIf()
6102965
@hsonne
Add shortcuts for all used kwb.utils functions
e0f8809
@hsonne
Get rid of calls to kwb.utils::hsQuoteChr()
3ca5f51
@hsonne
Merge pull request #13 from KWB-R/clean
02e099e 
Clean
@hsonne
Make code more compact
ed3264a
@hsonne
Use the pipe operator, simplify
bf6c350
@hsonne
Reuse stop_formatted()
d980dae
@hsonne
Return early, use pipe operator
1e4e8c6
@hsonne
Simplify variable name, use pipe operator
8cef64d
@hsonne
Use pipe operator
6533695
@hsonne
Use helper variable "nchars"
aee3673
@hsonne
Move functions between files
09f0795
@hsonne
Update Rd file
77be24e
@hsonne
Allow to pass arguments through to parse()
6fe61e1
@hsonne
Document interesting base function in vignette
51fb253
@hsonne
Add find_function_name_duplicates()
144b4d6
@hsonne
Merge branch 'dev' into clean
e3b0241
@hsonne
Add tests with kwb.test::cretate_test_files()
a281bc9
@hsonne
Add tests and "fill" empty tests
488b5cb
@hsonne
Fix documentation of ... args
f077d66
@hsonne
Merge pull request #14 from KWB-R/clean
0972a65 
Clean again
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@hsonne