Initialize precompiles in InitGenesis #57
Conversation
evgeniy-scherbina
force-pushed
the
precompiles-initialization-v2
branch
2 times, most recently
from
9894b45
to
98311b4
Compare
| stateDB.SetNonce(addr, PrecompileNonce) | ||
| // Set the code of the precompile's address to a non-zero length byte slice to ensure that the precompile | ||
| // can be called from within Solidity contracts. Solidity adds a check before invoking a contract to ensure | ||
| // that it does not attempt to invoke a non-existent contract. | ||
| stateDB.SetCode(addr, PrecompileCode) |
There was a problem hiding this comment.
We could use Keeper.SetAccount() for nonce+codehash and Keeper.SetCode directly instead of using StateDB since we don't need the snapshot/rollback/commit features of StateDB.
SetCode also is global mapping of codeHash to code too, so we only need to set the code once (still need to set codehash in account)
There was a problem hiding this comment.
This task was split into 2 tasks:
- Init precompiles in
InitGenesis- this part is postponed, Nick finalizes the spec - Init precompiles in
UpdateParams- this part is implemented here: Initialize precompiles in UpdateParams #58
This PR will be closed, sorry for confusion.
There was a problem hiding this comment.
and yeah, in #58 I'm directly using evmKeeper instead of StateDB
| @@ -68,7 +68,14 @@ func (k *Keeper) NewEVM( | |||
| tracer = k.Tracer(ctx, msg, cfg.ChainConfig) | |||
| } | |||
| vmConfig := k.VMConfig(ctx, msg, cfg, tracer) | |||
| return k.evmConstructor(blockCtx, txCtx, stateDB, cfg.ChainConfig, vmConfig) | |||
|
|
|||
| enabledPrecompiles := k.GetParams(ctx).EnabledPrecompiles | |||
There was a problem hiding this comment.
Params is in EVMConfig so we don't need to fetch it again - cfg.Params.EnabledPrecompiles
evgeniy-scherbina
force-pushed
the
precompiles-initialization-v2
branch
from
657942a
to
b3ff7b3
Compare
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days-before-close if no further activity occurs. |
Moved to #58
PR is deprecated,
Initialize precompiles in InitGenesisshould follow these guildelines: https://kava-labs.atlassian.net/wiki/spaces/ENG/pages/1469448211/Module+Genesis+GuidelinesPR breaks this requirement:
ExportGenesis(InitGenesis(genesisState)) == genesisState, because we callSetNonce&SetCodein InitGenesis which creates evm accounts, then these accounts will be exported inExportGenesis.We should instead rely on GenesisAccount{ 0x100…0, 0x01, []State{}) being in the genesis state for each enabled precompile