Improve x/evm genesis state testing #69
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
extra param sorting and uniqueness tests; remove legacy validations used for old param store; add enabled precompiles to params constructor and default params
complexity of test cases; prevent access of key before validation; and use empty struct map for uniq checks
was the same, however did not check it was actually a copy, so instead of improving tests, remove the unused code
that did not match test name; increase test coverage and confidence; refactor uniqueness check to use struct map and to not access account fields until after validations have run
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improves test coverage of genesis state and tests explicit errors for all validations, ensuring no false positives for changed logic or modified test data.
No behavior changes to validation logic are made here -- only slight refactors of order and error wrapping.