feat: add dai to internal testnet hard money markets #2027
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karzak
requested review from
rhuairahrighairidh,
pirtleshell,
drklee3,
nddeluca,
DracoLi,
evgeniy-scherbina,
sesheffield,
boodyvo and
lbayas
as code owners
boodyvo
reviewed
Sep 26, 2024
| "market_id": "dai:usd:30", | ||
| "base_asset": "dai", | ||
| "quote_asset": "usd", | ||
| "oracles": [ |
There was a problem hiding this comment.
Do we have oracle for internal testnet? Or is it just a required value?
There was a problem hiding this comment.
Good question, I'm not sure where the private key for kava1hdn83q3srldcpan4ex2v4npuae8hmnfrps3e6h is defined 🤔
There was a problem hiding this comment.
We just hard code the prices in the pricefeed and set them to never expire:
kava/ci/env/kava-internal-testnet/genesis.json
Line 3555 in ee4fc56
nddeluca
approved these changes
Sep 26, 2024
| "loan_to_value": "0.500000000000000000" | ||
| }, | ||
| "spot_market_id": "dai:usd:30", | ||
| "conversion_factor": "1000000000000000000", |
| @@ -121,6 +121,7 @@ npx hardhat --network "${ERC20_DEPLOYER_NETWORK_NAME}" mint-erc20 "$AXL_BUSD_CON | |||
| npx hardhat --network "${ERC20_DEPLOYER_NETWORK_NAME}" mint-erc20 "$AXL_XRPB_CONTRACT_ADDRESS" "$DEV_TEST_WALLET_ADDRESS" 1000000000000000000000 | |||
| npx hardhat --network "${ERC20_DEPLOYER_NETWORK_NAME}" mint-erc20 "$AXL_BTCB_CONTRACT_ADDRESS" "$DEV_TEST_WALLET_ADDRESS" 1000000000000000000000 | |||
| npx hardhat --network "${ERC20_DEPLOYER_NETWORK_NAME}" mint-erc20 "$WBTC_CONTRACT_ADDRESS" "$DEV_TEST_WALLET_ADDRESS" 10000000000000 | |||
| npx hardhat --network "${ERC20_DEPLOYER_NETWORK_NAME}" mint-erc20 "$DAI_CONTRACT_ADDRESS" "$DEV_TEST_WALLET_ADDRESS" 10000000000000000000000000 | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates internal testnet genesis to include dai money market and associated pricefeed changes. Updates seed script to include dai as as evm conversion pair. This enables testing of 18 decimal money markets on internal testnet.
Checklist