[FEAT] 컨텐츠 preview, search, scrap-count 에 isPointRequired 추가 #344
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mooncw
reviewed
Nov 6, 2024
Comment on lines
419
to
430
| // isPointRequired를 col로 받기 위해 확인하는 쿼리, 비로그인 상태 false 리턴 | ||
| private Expression<?> getIsPointRequiredByUserId(Long userId, NumberPath<Long> contentId) { | ||
| return userId != null ? | ||
| JPAExpressions | ||
| .selectOne() | ||
| .from(paymentContentHistoryEntity) | ||
| .where(isContentExpired(paymentContentHistoryEntity.expiredAt) | ||
| .and(paymentContentHistoryEntity.contentId.eq(contentId)) | ||
| .and(paymentContentHistoryEntity.userId.eq(userId))) | ||
| .exists() | ||
| : Expressions.constant(false); | ||
| } |
There was a problem hiding this comment.
IsPointRequired 가 true라면 Point를 내야 content를 볼 수 있다고 생각이 드는데요.
만약 그렇다면 결과가 비로그인시에는 true고 paymentContentHistoryEntity에 존재한다면 false여야 할 것 같습니다.
There was a problem hiding this comment.
맞네요 수정했습니다
추가로 exists 가 아니라 notExists 여야 포인트가 필요할때 true가 리턴되도록 수정했습니
mooncw
reviewed
Nov 6, 2024
Comment on lines
438
to
439
| .and(expiredAt.year().gt(today.getYear()) | ||
| .or(expiredAt.year().eq(today.getYear()) |
There was a problem hiding this comment.
gt와 eq를 합친 ge 메서드가 있었던 거 같은데 말이죠..
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR 타입 (하나 이상의 PR 타입을 선택해주세요)
변경 사항
참고 사항
셀프 체크리스트