[FEAT] 퀴즈 포인트 및 퀴즈 기록 기능 추가 #374
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mooncw
reviewed
Nov 14, 2024
Comment on lines
26
to
29
|
|
||
| public QuestionInfo.Hint getHint(QuestionCommand.ViewHint command) { | ||
| return questionService.getHint(command); | ||
| } |
There was a problem hiding this comment.
명령자 입장에서는 힌트를 가져와라 인데, 명령의 의미를 포함한다면 View 보다 Get이 맞지 않을까라는 생각이 듭니다.
There was a problem hiding this comment.
네 수정했습니다 DTO도 맞춰서 GetHint로 수정되었습니다
mooncw
reviewed
Nov 14, 2024
Comment on lines
57
to
59
| // 대시 보드 를 위해 문제 기록 저장 | ||
| questionHistoryStore.updateQuestionHistory(command.userId(), command.questionId(), isCorrect); | ||
|
|
There was a problem hiding this comment.
저는 DateProvider 메서드에 히스토리에 기록한다는 의미를 담는 record 라는 동사가 더 나은 것 같다고 생각하는데 어떻게 생각하시나요?
mooncw
reviewed
Nov 14, 2024
Comment on lines
31
to
34
| @Builder | ||
| public record Hint( | ||
| String hint | ||
| ) { |
There was a problem hiding this comment.
여기서만 이렇게 보이는 것 같아요
mooncw
reviewed
Nov 14, 2024
Comment on lines
67
to
69
| return QuestionInfo.Hint.builder() | ||
| .hint(this.findQuestionByQuestionId(questionId).getHint()) | ||
| .build(); |
There was a problem hiding this comment.
QuestionInfo.Hint의 메서드로 생성하시는 건 어떠신가요? of 처럼..
There was a problem hiding this comment.
QuestionInfo.Detail.of(questionDocument), QuestionInfo.Hint.of(this.findQuestionByQuestionId(questionId).getHint())
로 수정되었습니다
mooncw
reviewed
Nov 14, 2024
Comment on lines
65
to
69
| public void updateQuestionHistory(Boolean isCorrect) { | ||
| if((this.firstTry).equals(Boolean.FALSE)){ | ||
| this.finalTry = isCorrect; | ||
| } | ||
| } |
There was a problem hiding this comment.
다른 메서드로 변경하면서 삭제되지 않았었네요 수정했습니다
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR 타입 (하나 이상의 PR 타입을 선택해주세요)
변경 사항
참고 사항
셀프 체크리스트