feat : 반응형 ui 적용 중 #227
Merged
feat : 반응형 ui 적용 중 #227
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…into 194-design-responsive-web-design
3 tasks
godhyzzang
reviewed
Nov 12, 2024
Comment on lines
+58
to
+63
| <input | ||
| type="checkbox" | ||
| checked={!!item.status} | ||
| readOnly | ||
| className="h-5 w-5 text-violet-600" | ||
| /> |
There was a problem hiding this comment.
p2 : input이 보이면clickable한 느낌을 줘서 readOnly라면 Input태그 말고 다른 빨간불, 초록불 등 다른 방식으로 보여주는게 좋을 것 같아요~
Comment on lines
+110
to
+131
| <TooltipTrigger> | ||
| <div className="flex flex-col items-center gap-1"> | ||
| <div | ||
| className={`w-8 rounded-md ${ | ||
| day.completedMissions > 0 && | ||
| day.completedMissions === 1 | ||
| ? 'bg-violet-200' | ||
| : day.completedMissions === 2 | ||
| ? 'bg-violet-400' | ||
| : 'bg-violet-600' | ||
| }`} | ||
| style={{ | ||
| height: `${day.completedMissions * 20}px`, | ||
| }} | ||
| /> | ||
| <span className="text-xs text-gray-500"> | ||
| {formatDate(day.date)} | ||
| </span> | ||
| </div> | ||
| </TooltipTrigger> | ||
| <TooltipContent> | ||
| <p> |
There was a problem hiding this comment.
p2 : mobile learningTracker처럼처럼 몇 개 성공했는지 숫자가 보이는 편이 좋을 것 같아요~
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📄 Description of the PR
🔧 What has been changed?
📸 Screenshots / GIFs (if applicable)
✅ Checklist