Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEAT] 경매 상세 페이지 사진 영역 구현 #58

Merged
merged 11 commits into from
Oct 15, 2024
Merged

Conversation

haejinyun
Copy link
Collaborator

What is this PR? 🔍

Changes 📝

  • 상품의 사진을 보여주는 영역을 개발하였습니다.
    • 선택 된 사진은 테두리가 생깁니다.
  • 상세페이지의 구조가 조금 바뀌었습니다. 이는 Q&A와 함께 진행하며 변경된 요소입니다.

ScreenShot 📷

스크린샷 2024-10-14 오후 4 03 50
스크린샷 2024-10-14 오후 4 03 56
스크린샷 2024-10-14 오후 4 04 08

Precaution

QnA를 진행하며 중간에 진행하던 것을 잘라서 pr을 올리는 것이라 없는 파일 혹은 주석이 있을 수 있습니다.

✔️ Please check if the PR fulfills these requirements

  • It's submitted to the correct branch, not the develop branch unconditionally?
  • If on a hotfix branch, ensure it targets main?
  • There are no warning message when you run npm run lint

@haejinyun haejinyun changed the title Feat/#56 [FEAT] 경매 상세 페이지 사진 영역 구현 Oct 14, 2024
Copy link
Collaborator

@kimeodml kimeodml left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다! 추후에 위지윅 에디터 추가해야 겠네요

});

export const subImageWrapperButton = styleVariants({
active: {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

borderSizing:'border-box' 넣어주세요!

@haejinyun haejinyun self-assigned this Oct 15, 2024
@haejinyun haejinyun merged commit 88c3747 into develop Oct 15, 2024
1 check passed
@haejinyun haejinyun deleted the feat/#56 branch October 15, 2024 05:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEAT] 입찰 detail page 사진 영역 구현
2 participants