Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: 캘린더 컴포넌트 연동 #39

Merged
merged 2 commits into from
Oct 1, 2024

Conversation

Yejin0O0
Copy link
Collaborator

What is this PR? 🔍

Changes 📝

  • shadcn에서 calendar 컴포넌트 생성하여 작업했습니다.
  • DayCell이라는 컴포넌트를 통해 날짜 셀의 컴포넌트를 커스텀할 수 있습니다.

ScreenShot 📷

image

Precaution

  • 스타일링 작업은 새로 이슈 파서 작업하겠습니다.
  • TODO: 백엔드 연동 전 mock data type 정의

@Yejin0O0 Yejin0O0 added beforeLunch🍕 점심 전까지 리뷰가 필요합니다. feat✨ 기능 구현 labels Sep 27, 2024
@Yejin0O0 Yejin0O0 self-assigned this Sep 27, 2024
@iamgyu iamgyu self-requested a review September 30, 2024 03:24
Copy link
Contributor

@iamgyu iamgyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

p4: precaution에 작성해주신대로 스타일링만 수정되면 될 것 같습니다!

const dayScheduleList = scheduleList.filter((schedule) => {
// schedule.date === date;
const scheduleDate = new Date(schedule.date);
console.log(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

p3: 혹시 console.log를 남기신 이유가 있을까요??

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

디버깅 과정에서 만들어 두었던 코드를 미처 제거하지 못했습니다ㅠㅠ 제거 후 다시 커밋하도록 하겠습니다!

@Yejin0O0 Yejin0O0 merged commit 564a707 into develop Oct 1, 2024
1 check passed
@Yejin0O0 Yejin0O0 deleted the 35-feat-create-a-calendar-component-2h branch October 1, 2024 04:30
iamgyu pushed a commit that referenced this pull request Oct 14, 2024
* feat: 캘린더 컴포넌트 연동

* chore: console.log 제거
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
beforeLunch🍕 점심 전까지 리뷰가 필요합니다. feat✨ 기능 구현
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[feat] Create a Calendar Component (2H)
2 participants