Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
5 tasks
ShineCorine
reviewed
Dec 18, 2023
There was a problem hiding this comment.
asciidoctor.outputDir 은 환경별수에 별도로 등록하면 되는건가요?
There was a problem hiding this comment.
환경변수에 등록하실 필요는 없을것 같아요 !!
ShineCorine
approved these changes
Dec 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Type
돌아오는 주 부터 역할 분담 및 기능 작성을 위해 러닝커브가 있었던 부분 (Geometry 객체를 다루는 부분이라던지..)
을 감안하여 공부하고 예시 엔티티를 작성 및 리뷰 받고 싶어서 PR 날립니다!
Related Issues
#63
What does this PR do?
Other information
저도 학습을 하면서 한거라 엔티티를 이런 구조로 작성한 경험이 없어서 리뷰가 꼭 필요할 듯 합니다 (예상치 못한 문제가 있으면 안되니까요..ㅎㅎ)