Add SPV_AMDX_shader_enqueue version 2 support #5838
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could you please rebase on main and update the spirv-headers hash in DEPS to point to at least the merged headers for this extension? |
* Update SPIRV-Headers Co-authored-by: Dan Brown <daniel.brown@amd.com> Co-authored-by: Maciej Jesionowski <maciej.jesionowski@amd.com>
yavn
force-pushed
the
SPV_AMDX_shader_enqueue_v2
branch
from
6e411f5 to
bef6468
Compare
|
Hi @alan-baker , done and done. |
alan-baker
requested changes
Oct 10, 2024
There was a problem hiding this comment.
Overall there seem to be a lack of tests for this functionality. Please add some tests for the new validation.
Separately, when reading the spec for this extension you seem to be validating things that are missing from the spec. I'd suggest double checking and updating the extension text to match this validation.
pradyumans
reviewed
Oct 11, 2024
s-perron
reviewed
Oct 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The relevant SPIR-V changes are posted in the following PRs: