Skip to content
This repository has been archived by the owner on Oct 2, 2020. It is now read-only.

Add 6AL5 twin diode tube #2797

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

bitomaxsp
Copy link

@bitomaxsp bitomaxsp commented Jun 11, 2020

Add 6AL5 twin diode tube symbol

Datasheet URL: https://frank.pocnet.net/sheets/093/6/6AL5.pdf


All contributions to the kicad library must follow the KiCad library convention

Thanks for creating a pull request to contribute to the KiCad libraries! To speed up integration of your PR, please check the following items:

  • Provide a URL to a datasheet for the symbol(s) you are contributing
  • Provide a screenshot of the symbol(s) from the symbol editor with the pin types visible
  • Ensure that the associated footprints match the official footprint library
    • A new fitting footprint must be submitted if the library does not yet contain one.
  • If there are matching footprint PRs, provide link(s) as appropriate
  • Check the output of the Travis automated check scripts - fix any errors as required
  • Give a reason behind any intentional library convention rule violation.

Be patient, we maintainers are volunteers with limited time and need to check your contribution against the datasheet. You can speed up the process by providing all the necessary information (see above). And you can speed up the process even more by providing additional info like the screenshot of the symbol editor pin table (or for high pin counts converted to csv) sorted in the same way as the pin table in the datasheet and a direct link to the datasheet page that contains the pin table.

@CLAassistant
Copy link

CLAassistant commented Jun 11, 2020

CLA assistant check
All committers have signed the CLA.

@bitomaxsp bitomaxsp force-pushed the add-6al5 branch 2 times, most recently from b14279e to 592608c Compare June 11, 2020 12:30
@bitomaxsp
Copy link
Author

bitomaxsp commented Jun 12, 2020

Unit A
image

@bitomaxsp
Copy link
Author

bitomaxsp commented Jun 12, 2020

Unit B
image

@bitomaxsp
Copy link
Author

bitomaxsp commented Jun 12, 2020

Unit C - Heater
image

@bitomaxsp bitomaxsp force-pushed the add-6al5 branch 3 times, most recently from e8f61f1 to 4e0f4ba Compare June 12, 2020 08:48
@myfreescalewebpage myfreescalewebpage added Addition Adds new symbols to library Pending reviewer A pull request waiting for a reviewer labels Jun 17, 2020
@myfreescalewebpage
Copy link
Collaborator

To be reviewed after #1649 which is making a large change in the lib

@myfreescalewebpage myfreescalewebpage self-assigned this Sep 20, 2020
@myfreescalewebpage myfreescalewebpage removed the Pending reviewer A pull request waiting for a reviewer label Sep 20, 2020
@myfreescalewebpage
Copy link
Collaborator

@bitomaxsp first steps of the review right now:

  • Fp filter should be Valve*Mini*P*
  • Unit C: the design of the heater should be consistent with the design on other symbol
  • Unit C: can you add the shielding pin please ?

Joel

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Addition Adds new symbols to library
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants