Skip to content
This repository has been archived by the owner on Oct 2, 2020. It is now read-only.

Added LAN8742A #2817

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Added LAN8742A #2817

wants to merge 3 commits into from

Conversation

Misaka0x2730
Copy link
Contributor

Added LAN8742A - 10/100Base-T/TX Ethernet PHY.
image
Datasheet: http://ww1.microchip.com/downloads/en/DeviceDoc/8742a.pdf

All contributions to the kicad library must follow the KiCad library convention

Thanks for creating a pull request to contribute to the KiCad libraries! To speed up integration of your PR, please check the following items:

  • Provide a URL to a datasheet for the symbol(s) you are contributing
  • Provide a screenshot of the symbol(s) from the symbol editor with the pin types visible
  • Ensure that the associated footprints match the official footprint library
    • A new fitting footprint must be submitted if the library does not yet contain one.
  • If there are matching footprint PRs, provide link(s) as appropriate
  • Check the output of the Travis automated check scripts - fix any errors as required
  • Give a reason behind any intentional library convention rule violation.

Be patient, we maintainers are volunteers with limited time and need to check your contribution against the datasheet. You can speed up the process by providing all the necessary information (see above). And you can speed up the process even more by providing additional info like the screenshot of the symbol editor pin table (or for high pin counts converted to csv) sorted in the same way as the pin table in the datasheet and a direct link to the datasheet page that contains the pin table.

@myfreescalewebpage myfreescalewebpage added Addition Adds new symbols to library Pending reviewer A pull request waiting for a reviewer labels Jun 25, 2020
@myfreescalewebpage myfreescalewebpage self-assigned this Sep 5, 2020
@myfreescalewebpage myfreescalewebpage removed the Pending reviewer A pull request waiting for a reviewer label Sep 5, 2020
@myfreescalewebpage
Copy link
Collaborator

myfreescalewebpage commented Sep 5, 2020

Hi @Misaka0x2730 , thanks for contributing,

A few comments I have during my review:

  • The design of the symbol with the RMII pin rectangle is quite old and can be simplified, we prefer something more classial, see LAN9514 for example
  • Package should be Package_DFN_QFN:QFN-24-1EP_4x4mm_P0.5mm_EP2.5x2.5mm (to be submitted)
  • Name of pin 2: LED2/~INT~/~PME~/~INTSEL~
  • Name of pin 3: LED1/~INT~/~PME~/REGOFF
  • Name of pin 14: ~INT~/REFCLKO
  • Name of pin 15: ~RST
  • Pins 22 and 23 should be Input
  • Pin 5 should be Input
  • Pin 4 should be Output
  • Pin 24 should be Passive
  • Pins 7, 8 and 11 should be Bidirectional

Cheers,
Joel

@myfreescalewebpage myfreescalewebpage added the Pending footprint Pending footprint acceptance before merging label Sep 5, 2020
@myfreescalewebpage
Copy link
Collaborator

Thanks, need now to wait the footprint

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Addition Adds new symbols to library Pending footprint Pending footprint acceptance before merging
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants