Skip to content
This repository has been archived by the owner on Oct 2, 2020. It is now read-only.

Added new RF module E22-900M30S-SX1262 #2826

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

TheSillyMouse
Copy link
Contributor

@TheSillyMouse TheSillyMouse commented Jun 27, 2020

Added new RF module E22-900M30S-SX1262

Datasheet
http://www.ebyte.com/en/downpdf.aspx?id=453

Screenshot
image

Footprint
KiCad/kicad-footprints#2345


All contributions to the kicad library must follow the KiCad library convention

Thanks for creating a pull request to contribute to the KiCad libraries! To speed up integration of your PR, please check the following items:

  • Provide a URL to a datasheet for the symbol(s) you are contributing
  • Provide a screenshot of the symbol(s) from the symbol editor with the pin types visible
  • Ensure that the associated footprints match the official footprint library
    • A new fitting footprint must be submitted if the library does not yet contain one.
  • If there are matching footprint PRs, provide link(s) as appropriate
  • Check the output of the Travis automated check scripts - fix any errors as required
  • Give a reason behind any intentional library convention rule violation.

Be patient, we maintainers are volunteers with limited time and need to check your contribution against the datasheet. You can speed up the process by providing all the necessary information (see above). And you can speed up the process even more by providing additional info like the screenshot of the symbol editor pin table (or for high pin counts converted to csv) sorted in the same way as the pin table in the datasheet and a direct link to the datasheet page that contains the pin table.

@CLAassistant
Copy link

CLAassistant commented Jun 27, 2020

CLA assistant check
All committers have signed the CLA.

@aris-kimi
Copy link
Collaborator

aris-kimi commented Jun 27, 2020

Hi @TheSillyMouse , i am not a librarian, i just want to point out that VCC and GND pins should be stacked, this will allow the symbol to become smaller in width.

Thank you for this addition.

@TheSillyMouse
Copy link
Contributor Author

Hi @TheSillyMouse , i am not a librarian, i just want to point out that VCC and GND pins should be stacked, this will allow the symbol to become smaller in width.

Thank you for this addition.

Thank you for your comment.
I tend not to stack GND and VCC pins so you can easily know what pins are connected to ground and power supply rail.

Is that mandatory?

@aris-kimi
Copy link
Collaborator

Is that mandatory?

Hi @TheSillyMouse , according to KLC S4.3 rules for pin stacking, i think it is..

@TheSillyMouse
Copy link
Contributor Author

TheSillyMouse commented Jun 29, 2020

Is that mandatory?

Hi @TheSillyMouse , according to KLC S4.3 rules for pin stacking, i think it is..

@aris-kimi Fixed!
Thank you!

Copy link
Collaborator

@aris-kimi aris-kimi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @TheSillyMouse , thank you for this fix.
Now you should

  • add a link to the footprint PR.

  • check travis output and try to fix its output leaving as an error only violating S5.1

  • change description to something like 2.5-5V, 1W, 12km, 850~930MHz, 30dBm

  • change keywords to something like lora rf wireless module

  • add footprint filter something like E22*900M30S*SX1262*

  • adjust symbol's width and height by 200mil

To correct footprint errors better wait for the footprint PR to merge.

@TheSillyMouse
Copy link
Contributor Author

Hi @TheSillyMouse , thank you for this fix.
Now you should

* [ ]  add a link to the footprint PR.

* [ ]  check travis output and try to fix its output leaving as an error only violating S5.1

* [ ]  change description to something like `2.5-5V, 1W, 12km, 850~930MHz, 30dBm`

* [ ]  change keywords to something like `lora rf wireless module`

* [ ]  add footprint filter something like `E22*900M30S*SX1262*`

To correct footprint erros better wait for the footprint PR to merge.

Thanks for your help!

Copy link
Collaborator

@aris-kimi aris-kimi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@TheSillyMouse I do not think force-push is acceptable or might be a reason for conflicts, description though, should be comma seperated, check other symbols and try to spot differences.
I didn't see any change at travis errors..

@TheSillyMouse
Copy link
Contributor Author

@TheSillyMouse I do not think force-push is acceptable or might be a reason for conflicts, description though, should be comma seperated, check other symbols and try to spot differences.
I didn't see any change at travis errors..

Okay I'll push separated commits.

@myfreescalewebpage myfreescalewebpage added Addition Adds new symbols to library Pending reviewer A pull request waiting for a reviewer labels Jul 5, 2020
@myfreescalewebpage myfreescalewebpage self-assigned this Jul 5, 2020
@myfreescalewebpage myfreescalewebpage removed the Pending reviewer A pull request waiting for a reviewer label Jul 5, 2020
@myfreescalewebpage
Copy link
Collaborator

Hello @TheSillyMouse thanks for this symbol.

And thanks to @aris-kimi for the comments. I will add the followings:

  • The name of the symbol should be "E22-900M30S" only
  • The footprint should be RF_Module:E22-900M30S and the footprint filter E22*900M30S*
  • Travis report an error about the pin offset
  • Name of pin 15 should be ~RST
  • The pin should be grouped by functions. Also for this kind of device DIO pins can be on the right bellow ANT because they are sometimes used to drive RF parts.

Joel

@myfreescalewebpage myfreescalewebpage added the Pending footprint Pending footprint acceptance before merging label Jul 5, 2020
@myfreescalewebpage
Copy link
Collaborator

@TheSillyMouse ping

@myfreescalewebpage
Copy link
Collaborator

No news of the author, indicate this is Abandoned

@myfreescalewebpage myfreescalewebpage added the Abandoned Original author has stopped working on the PR label Sep 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Abandoned Original author has stopped working on the PR Addition Adds new symbols to library Pending footprint Pending footprint acceptance before merging
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants