Skip to content
This repository has been archived by the owner on Oct 2, 2020. It is now read-only.

Adding all BDxxFC0 series LDO regulator #2853

Open
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

JonathSpirit
Copy link
Contributor

@JonathSpirit JonathSpirit commented Jul 10, 2020

Adding all BDxxFC0 series LDO regulator

datasheet :
https://fscdn.rohm.com/en/products/databook/datasheet/ic/power/linear_regulator/bdxxfc0wefj-e.pdf

Annotation 2020-07-10 160453

Variable version (BD00FC0WFP, BD00FC0WEFJ) :

varaible to252

varaible htsop

Fix without enable version (BDxxFC0FP) :

fix sans w

Alias :

fix sans w alias

Fix with enable version TO-263-5 (BDxxFC0WFP) :

fix avec w to252

Alias :

fix avec w to252 alias

Fix with enable version HTSOP-8 (BDxxFC0WEFJ) :

fix avec w htsop

Alias :

fix avec w htsop alias


All contributions to the kicad library must follow the KiCad library convention

Thanks for creating a pull request to contribute to the KiCad libraries! To speed up integration of your PR, please check the following items:

  • Provide a URL to a datasheet for the symbol(s) you are contributing
  • Provide a screenshot of the symbol(s) from the symbol editor with the pin types visible
  • Ensure that the associated footprints match the official footprint library
    • A new fitting footprint must be submitted if the library does not yet contain one.
  • If there are matching footprint PRs, provide link(s) as appropriate
  • Check the output of the Travis automated check scripts - fix any errors as required
  • Give a reason behind any intentional library convention rule violation.

Be patient, we maintainers are volunteers with limited time and need to check your contribution against the datasheet. You can speed up the process by providing all the necessary information (see above). And you can speed up the process even more by providing additional info like the screenshot of the symbol editor pin table (or for high pin counts converted to csv) sorted in the same way as the pin table in the datasheet and a direct link to the datasheet page that contains the pin table.

@JonathSpirit
Copy link
Contributor Author

JonathSpirit commented Jul 10, 2020

Violating S3.1

  • Origin is centered on the middle of the symbol

I've taken as an example other symbols.

Violating S4.2

  • Pins should be arranged by function
  • Positive power pins should be placed at top of symbol

The power pins are often on the sides for regulators.

@diegoherranz diegoherranz added Pending reviewer A pull request waiting for a reviewer Addition Adds new symbols to library labels Jul 11, 2020
@aris-kimi
Copy link
Collaborator

Hi @JonathSpirit , thankyou for your contribution.

Footprint filters should be:
line 570: HTSOP*1EP*3.9x4.9mm*P1.27mm*
line 594: TO?263*
line 641: TO?252*
line 661: HTSOP*1EP*3.9x4.9mm*P1.27mm*
line 686: TO?263*

And also a suggestion, i think it would be better for those symbols without enable, to totaly remove from decription, and leave it only to those symbols which applies.

Not a full review, only a few quick comments..

@JonathSpirit
Copy link
Contributor Author

Thanks for the review,

I'm just confused for the TO263/TO252 filters. For example, TO-263-5_TabPin3 is not compatible with "WFP" symbols because pin 3 is not connected instead of GND so the filter should contain "TabPin6" ?

And the filter should also logically contain the number of pins ? (TO-263-5)

@myfreescalewebpage
Copy link
Collaborator

@JonathSpirit the fixes of @aris-kimi are correct. Fp filter are sometimes very permissive but it is normal + fp filter never contains the number of pins.

One comment I have to do looking at the screenshots: the size of the outline is not usual for regulators. Height should be increased by 100mil.

Joel

PS @aris-kimi would you liek to continue the review here or not ?

@evanshultz
Copy link
Collaborator

It looks like the width can be decreased as well.

@JonathSpirit
Copy link
Contributor Author

image

image

image

I resize all of the symbols by taking the existing regulators as an example (The only concern is that they are all different) and modify the footprint filters

DEF BD00FC0WFP U 0 20 Y Y 1 F N
F0 "U" 0 300 50 H V C CNN
F1 "BD00FC0WFP" 0 200 50 H V C CNN
F2 "Package_TO_SOT_SMD:TO-263-5_TabPin6" 0 100 50 H I C CNN
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

package must be TO-252-5
εικόνα
There is no 263 at the ds. Please fix those parts that are wrong (if others) and adjust filters.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Addition Adds new symbols to library Pending reviewer A pull request waiting for a reviewer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants