-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add binary and varbinary SQLDataType #124
base: next
Are you sure you want to change the base?
Conversation
Faster comparison and sorting of fields using binary and varbinary types in MySQL comparing to char and varchar. In case of binary/varbinary, comparison and sorting is based on the numeric values of the bytes in the values.
|
Codecov Report
@@ Coverage Diff @@
## master #124 +/- ##
=========================================
- Coverage 85.25% 85.16% -0.1%
=========================================
Files 43 43
Lines 3575 3579 +4
=========================================
Hits 3048 3048
- Misses 527 531 +4
Continue to review full report at Codecov.
|
Hey @Mladen-K , do the 3 SQL platforms (PostgresSQL, MySQL, and SQLite) that we support use the same notation? What I mean is does the Binary Type in Swift always translate to |
In PostgreSQL, there are both data types, although they are represented as BIT and BIT VARYING. Without testing on working PostgreSQL database, I can't tell for sure wether the generated query will generate required fields with "binary" and "varbinary". SQLite doesn't support binary types... |
I believe that instead of hardcoding a string in SwiftKuery, ideally we should add a case to the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please see my comment above
Ok, I'll see what I can do. |
Thanks |
http://www.sqlitetutorial.net/sqlite-data-types/ seems useful. |
Hey @Mladen-K , any news on this? |
@EnriqueL8, Just haven't had time to check it out. Sure will do in next few days. |
Thanks! |
Faster comparison and sorting of fields using binary and varbinary types in MySQL comparing to char and varchar. In case of binary/varbinary, comparison and sorting is based on the numeric values of the bytes in the values.