Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Confirm tests fail on PHP 8.2 #94

Merged
merged 1 commit into from
Dec 4, 2023

Conversation

GrahamCampbell
Copy link
Contributor

No description provided.

@robbieaverill
Copy link
Collaborator

Merging as a "add PHP 8.1 and 8.2 to CI" change, thanks!

@robbieaverill robbieaverill merged commit b101818 into KnpLabs:master Dec 4, 2023
4 checks passed
@GrahamCampbell
Copy link
Contributor Author

Hmmm, the tests should be failing here. Are deprecation errors silenced, or do the tests not actually cover the code that is broken?

@GrahamCampbell GrahamCampbell deleted the patch-2 branch December 4, 2023 18:14
@robbieaverill
Copy link
Collaborator

robbieaverill commented Dec 4, 2023

Perhaps the API fixtures need to be updated to include the new properties that are causing the deprecation warnings.

I added an example of this in #96

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants