Add API to rerequest a check run #1141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acrobat
requested changes
Sep 23, 2024
| */ | ||
| public function rerequest(string $username, string $repository, int $checkRunId) | ||
| { | ||
| $this->acceptHeaderValue = 'application/vnd.github.antiope-preview+json'; |
There was a problem hiding this comment.
Is this accept header required for this api endpoint? I don't seem to find it in the api docs.
There was a problem hiding this comment.
You are right, it is the wrong header. I replaced it with the correct one that is listed here
acrobat
requested changes
Sep 26, 2024
| */ | ||
| public function rerequest(string $username, string $repository, int $checkRunId) | ||
| { | ||
| $this->acceptHeaderValue = 'application/vnd.github+json '; |
There was a problem hiding this comment.
@Spea this is the default header so it doesn't need to be set here. The client will apply that one by default. So if you can remove this line, the PR is good to go!
php-github-api/lib/Github/Client.php
Lines 136 to 139 in 845545b
There was a problem hiding this comment.
Thank you for pointing that out. I removed it now.
This change adds a new method to rerequest a check run (see also https://docs.github.com/en/rest/checks/runs?apiVersion=2022-11-28#rerequest-a-check-run).
acrobat
approved these changes
Sep 26, 2024
|
Thanks @Spea! And congrats on your first contribution! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds a new method to rerequest a check run (see also https://docs.github.com/en/rest/checks/runs?apiVersion=2022-11-28#rerequest-a-check-run).