Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support feature selection for device #406

Open
wants to merge 10 commits into
base: master
Choose a base branch
from

Conversation

koubaa
Copy link
Contributor

@koubaa koubaa commented Dec 10, 2024

I encountered the following error

DEBUG:kp:[VALIDATION]: Validation - Validation Error: [ VUID-VkShaderModuleCreateInfo-pCode-08740 ] | MessageID = 0x6e224e9 | vkCreateShaderModule():  SPIR-V Capability Float64 was declared, but one of the following requirements is required (VkPhysicalDeviceFeatures::shaderFloat64).
The Vulkan spec states: If pCode is a pointer to SPIR-V code, and pCode declares any of the capabilities listed in the SPIR-V Environment appendix, one of the corresponding requirements must be satisfied (https://vulkan.lunarg.com/doc/view/1.3.296.0/windows/1.3-extensions/vkspec.html#VUID-VkShaderModuleCreateInfo-pCode-08740)

So I added the ability to 1) report the available features and 2) request features when creating the device.

koubaa added 3 commits December 10, 2024 09:33
Signed-off-by: koubaa <koubaa@github.com>
Signed-off-by: koubaa <koubaa@github.com>
Signed-off-by: koubaa <koubaa@github.com>
@koubaa koubaa changed the title Add more information about device to the python bindings Support feature selection for device Dec 10, 2024
koubaa added 5 commits December 10, 2024 10:34
Signed-off-by: koubaa <koubaa@github.com>
Signed-off-by: koubaa <koubaa@github.com>
Signed-off-by: koubaa <koubaa@github.com>
Signed-off-by: koubaa <koubaa@github.com>
Signed-off-by: koubaa <koubaa@github.com>
Signed-off-by: koubaa <koubaa@github.com>
@koubaa
Copy link
Contributor Author

koubaa commented Dec 10, 2024

I can't figure out why the python test is crashing. It works on my machine™

Signed-off-by: koubaa <koubaa@github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant