Add GOJIRA_KONG_REPO_URL environment variable to hold repo URL #63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Normally, gojira would construct the URL from GOJIRA_GIT_REMOTE and GOJIRA_REPO, both of which potentially get overridden and constructed by command line arguments and other environment variables. The new GOJIRA_KONG_REPO_URL environment variable overrides all of this to support environments that already have the required Kong repository cloned locally and need gojira to work with that instead
|
looks good. mind adding some lines to raise visibility -> https://github.com/Kong/gojira/blob/master/docs/manual.md ? |
Done in 50e0ac6 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Normally, gojira would construct the URL from GOJIRA_GIT_REMOTE and
GOJIRA_REPO, both of which potentially get overridden and constructed
by command line arguments and other environment variables. The
new GOJIRA_KONG_REPO_URL environment variable overrides all of this to
support environments that already have the required Kong repository
cloned locally and need gojira to work with that instead