Fix/mask auth passwords (#8110)

* Add mask property to sensitive authentication fields * Removed whitespace
Kong · Oct 24, 2024 · 327f16e · 327f16e
1 parent 7a67255
commit 327f16e
Show file tree

Hide file tree

Showing 5 changed files with 6 additions and 5 deletions.
diff --git a/packages/insomnia/src/ui/components/editors/auth/aws-auth.tsx b/packages/insomnia/src/ui/components/editors/auth/aws-auth.tsx
@@ -14,6 +14,7 @@ export const AWSAuth: FC = () => (
     <AuthInputRow
       label="Secret Access Key"
       property="secretAccessKey"
+      mask={true}
     />
     <AuthInputRow
       label="Region"

diff --git a/packages/insomnia/src/ui/components/editors/auth/basic-auth.tsx b/packages/insomnia/src/ui/components/editors/auth/basic-auth.tsx
@@ -8,7 +8,7 @@ export const BasicAuth: FC<{ disabled?: boolean }> = ({ disabled = false }) => (
   <AuthTableBody>
     <AuthToggleRow label="Enabled" property="disabled" invert disabled={disabled} />
     <AuthInputRow label="Username" property="username" disabled={disabled} />
-    <AuthInputRow label="Password" property="password" disabled={disabled} />
+    <AuthInputRow label="Password" property="password" mask disabled={disabled} />
     <AuthToggleRow
       label="Use ISO 8859-1"
       help="Check this to use ISO-8859-1 encoding instead of default UTF-8"

diff --git a/packages/insomnia/src/ui/components/editors/auth/bearer-auth.tsx b/packages/insomnia/src/ui/components/editors/auth/bearer-auth.tsx
@@ -7,7 +7,7 @@ import { AuthToggleRow } from './components/auth-toggle-row';
 export const BearerAuth: FC<{ disabled?: boolean }> = ({ disabled = false }) => (
   <AuthTableBody>
     <AuthToggleRow label="Enabled" property="disabled" invert disabled={disabled} />
-    <AuthInputRow label='Token' property='token' disabled={disabled} />
+    <AuthInputRow label='Token' property='token' mask disabled={disabled} />
     <AuthInputRow label='Prefix' property='prefix' disabled={disabled} />
   </AuthTableBody>
 );
diff --git a/packages/insomnia/src/ui/components/editors/auth/hawk-auth.tsx b/packages/insomnia/src/ui/components/editors/auth/hawk-auth.tsx
@@ -13,7 +13,7 @@ export const HawkAuth: FC = () => (
   <AuthTableBody>
     <AuthToggleRow label="Enabled" property="disabled" invert />
     <AuthInputRow label='Auth Id' property='id' />
-    <AuthInputRow label='Auth Key' property='key' />
+    <AuthInputRow label='Auth Key' property='key' mask />
     <AuthSelectRow
       label='Algorithm'
       property='algorithm'

diff --git a/packages/insomnia/src/ui/components/editors/auth/o-auth-1-auth.tsx b/packages/insomnia/src/ui/components/editors/auth/o-auth-1-auth.tsx
@@ -45,9 +45,9 @@ export const OAuth1Auth: FC = () => {
     <AuthTableBody>
       <AuthToggleRow label="Enabled" property="disabled" invert />
       <AuthInputRow label='Consumer Key' property='consumerKey' />
-      <AuthInputRow label='Consumer Secret' property='consumerSecret' />
+      <AuthInputRow label='Consumer Secret' property='consumerSecret' mask />
       <AuthInputRow label='Token Key' property='tokenKey' />
-      <AuthInputRow label='Token Secret' property='tokenSecret' />
+      <AuthInputRow label='Token Secret' property='tokenSecret' mask />
       <AuthSelectRow label='Signature Method' property='signatureMethod' options={signatureMethodOptions} />
       {signatureMethod === SIGNATURE_METHOD_RSA_SHA1 && <AuthPrivateKeyRow label='Private Key' property='privateKey' />}
       <AuthInputRow label='Callback URL' property='callback' />