fix: support generating values with faker.js in scripting #7454
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gatzjames
previously approved these changes
May 27, 2024
ihexxa
force-pushed
the
fix-script-val-gen
branch
from
393e0ef to
fe740d6
Compare
gatzjames
approved these changes
May 28, 2024
stefancruz
pushed a commit
to stefancruz/insomnia
that referenced
this pull request
Jun 30, 2024
* fix: support generating values with faker.js in scripting * fix: relax timeout for one case and remove a duplicated case * fix: test is flaky because of timeout * fix: incorrect test selector * fix: waiting before checking * fix: replace clicking with assertion * fix: relax the external timeout a bit
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
Ref: INS-3883
Changes
replaceInmethod support generating values with Faker.js