Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Key-Value Editor): Improve accessibility and make the items re-orderable #7465

Merged
merged 9 commits into from
Jun 5, 2024
Merged

feat(Key-Value Editor): Improve accessibility and make the items re-orderable #7465

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
961d7f4
remove unused components
gatzjames May 29, 2024
c2b2ed5
make read-only editors display nunjucks
gatzjames May 29, 2024
e4f285c
graphql toolbar css
gatzjames May 29, 2024
b3c0084
re-orderable key value editor
gatzjames May 29, 2024
5f4814d
move onChange to event handlers
gatzjames Jun 4, 2024
0319592
remove unused test
gatzjames Jun 4, 2024
a00e6d0
fix delete all/add updates
gatzjames Jun 4, 2024
4464bfe
clean up logs
gatzjames Jun 4, 2024
0ca0052
remove callbacks
gatzjames Jun 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 0 additions & 21 deletions packages/insomnia/src/ui/components/base/__tests__/editable.test.ts
View file
Open in desktop

This file was deleted.

111 changes: 0 additions & 111 deletions packages/insomnia/src/ui/components/base/editable.tsx
View file
Open in desktop

This file was deleted.

2 changes: 1 addition & 1 deletion packages/insomnia/src/ui/components/codemirror/one-line-editor.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -186,7 +186,7 @@ export const OneLineEditor = forwardRef<OneLineEditorHandle, OneLineEditorProps>
// Clear history so we can't undo the initial set
codeMirror.current?.clearHistory();
// Setup nunjucks listeners
if (!readOnly && handleRender && !settings.nunjucksPowerUserMode) {
if (handleRender && !settings.nunjucksPowerUserMode) {
codeMirror.current?.enableNunjucksTags(
handleRender,
handleGetRenderContext,
Expand Down
5 changes: 2 additions & 3 deletions packages/insomnia/src/ui/components/editors/body/graph-ql-editor.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ import { DefinitionNode, DocumentNode, GraphQLNonNull, GraphQLSchema, Kind, NonN
import { buildClientSchema, getIntrospectionQuery } from 'graphql/utilities';
import { Maybe } from 'graphql-language-service';
import React, { FC, useEffect, useRef, useState } from 'react';
import { Button } from 'react-aria-components';
import { Button, Toolbar } from 'react-aria-components';
import ReactDOM from 'react-dom';
import { useLocalStorage } from 'react-use';

Expand All @@ -28,7 +28,6 @@ import { CodeEditor, CodeEditorHandle } from '../../codemirror/code-editor';
import { GraphQLExplorer } from '../../graph-ql-explorer/graph-ql-explorer';
import { ActiveReference } from '../../graph-ql-explorer/graph-ql-types';
import { HelpTooltip } from '../../help-tooltip';
import { Toolbar } from '../../key-value-editor/key-value-editor';
import { useDocBodyKeyboardShortcuts } from '../../keydown-binder';
import { TimeFromNow } from '../../time-from-now';

Expand Down Expand Up @@ -470,7 +469,7 @@ export const GraphQLEditor: FC<Props> = ({
const canShowSchema = schema && !schemaIsFetching && !schemaFetchError && schemaLastFetchTime > 0;
return (
<div className="graphql-editor">
<Toolbar>
<Toolbar className="content-box sticky top-0 z-10 bg-[var(--color-bg)] flex flex-row border-b border-[var(--hl-md)] h-[var(--line-height-sm)] text-[var(--font-size-sm)]">
<Dropdown
aria-label='Operations Dropdown'
isDisabled={!state.operations.length}
Expand Down
Loading
Loading