Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add fetch timeout [INS-3911] #7467

Merged
merged 4 commits into from
Jun 5, 2024
Merged

feat: add fetch timeout [INS-3911] #7467

merged 4 commits into from
Jun 5, 2024

Conversation

CurryYangxx
Copy link
Member

@CurryYangxx CurryYangxx commented May 30, 2024

Changes:

  • add timeout for insomniaFetch
    • use abortController to cancel fetch when timeout

@CurryYangxx CurryYangxx marked this pull request as draft May 30, 2024 10:10
@CurryYangxx CurryYangxx changed the title feat: retry & timeout strategy feat: retry & timeout strategy [INS-3911] May 30, 2024
@CurryYangxx CurryYangxx marked this pull request as ready for review May 31, 2024 07:08
@CurryYangxx CurryYangxx requested a review from a team May 31, 2024 07:08
@jackkav
Copy link
Contributor

jackkav commented Jun 1, 2024

5xx seems too broadly scoped a backend validation error would cause a bunch of retries.

@CurryYangxx
Copy link
Member Author

CurryYangxx commented Jun 3, 2024

5xx seems too broadly scoped a backend validation error would cause a bunch of retries.

@jackkav I discussed with @notjaywu , and he advice client could retry when there is a server error resposne, so we decided to set 429 and 5xx.If you have any idea, we could talk about it here or in this ticket INS-3911

@jackkav
Copy link
Contributor

jackkav commented Jun 3, 2024

This is a very dangerous change and will contribute to further outages. I would advise removing all retry logic in this PR.

@CurryYangxx CurryYangxx changed the title feat: retry & timeout strategy [INS-3911] feat: add fetch timeout [INS-3911] Jun 5, 2024
@CurryYangxx CurryYangxx enabled auto-merge (squash) June 5, 2024 07:26
@CurryYangxx CurryYangxx merged commit eee7133 into develop Jun 5, 2024
7 checks passed
@CurryYangxx CurryYangxx deleted the feat/retry branch June 5, 2024 07:41
saisatishkarra pushed a commit that referenced this pull request Jun 5, 2024
* remove exponential backoff

* feat: improve err message when time out

---------

Co-authored-by: jackkav <jackkav@gmail.com>
Copy link

sentry-io bot commented Jun 12, 2024

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

  • ‼️ TypeError: Failed to fetch insomniaFetch(src/ui/insomniaFetch) View Issue

Did you find this useful? React with a 👍 or 👎

stefancruz pushed a commit to stefancruz/insomnia that referenced this pull request Jun 30, 2024
* remove exponential backoff

* feat: improve err message when time out

---------

Co-authored-by: jackkav <jackkav@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants