Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Response Tabs): Tabs with a menu inside are not accessible - Response Panes #7477

Merged
merged 9 commits into from
Jun 5, 2024

Conversation

gatzjames
Copy link
Contributor

@gatzjames gatzjames commented Jun 3, 2024

Highlights:

  • Updates the request pane's tabs to be keyboard accessible by moving the menu inside the tab panel
  • Fixes an issue where choosing Cancel when switching body type won't work
  • Improves GraphQL editor overflow by adding resizable panes and making navigation more accessible
  • Fixes overflow issue with tab panel content not scrolling properly
  • Fixes overflow issue with menus not scrolling when exceeding the screen limits

TODO:

  • Update e2e tests

Next steps:

  • Fix tab issues in Response Panes
  • Look into other tabs that might have the same issue

@gatzjames gatzjames self-assigned this Jun 3, 2024
@gatzjames gatzjames requested a review from a team June 3, 2024 14:39
@gatzjames gatzjames force-pushed the feat/tabs-accessibility branch 2 times, most recently from a1bb96d to 1b123bf Compare June 4, 2024 14:59
@gatzjames gatzjames force-pushed the feat/tabs-accessibility branch from 1b123bf to c2e535e Compare June 5, 2024 07:41
@gatzjames gatzjames requested a review from CurryYangxx June 5, 2024 07:41
@gatzjames gatzjames force-pushed the feat/tabs-accessibility branch from c2e535e to 23b12bd Compare June 5, 2024 09:19
@gatzjames gatzjames force-pushed the feat/tabs-accessibility branch from 23b12bd to 2732889 Compare June 5, 2024 09:19
@gatzjames gatzjames merged commit 79cc2ef into Kong:develop Jun 5, 2024
7 checks passed
@gatzjames gatzjames deleted the feat/tabs-accessibility branch June 5, 2024 10:05
Copy link

sentry-io bot commented Jun 12, 2024

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

  • ‼️ TypeError: Cannot read properties of undefined (reading 'target') saveChanges(ui/components/panes/request-group-p... View Issue

Did you find this useful? React with a 👍 or 👎

stefancruz pushed a commit to stefancruz/insomnia that referenced this pull request Jun 30, 2024
…onse Panes (Kong#7477)

* use thing scrollbars in the app

* fix menu/toast overflow content shift

* update content and auth dropdowns

* Update auth wrapper styles

* update body editors

* Request/request-group panes

* update request script editor

* update e2e tests

* remove log
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants