-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: multiple tabs - [INS-4225] #8151
base: develop
Are you sure you want to change the base?
Conversation
ada3f7a
to
ca2d22b
Compare
a8d050d
to
68c7cdf
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Found issue where tabs disappear when pressing OPTION + TAB in the UI after a few times
some suggestions for this PR or other follow-up PRs:
- allow for pressing CTRL + TAB / CTRL + SHIFT + TAB to alternate between tabs
- perhaps also allow the same for pressing CTRL + 1 (1 to 9) to go to 1st -> 9th tab, 0 being last tab?
- allow middle-mouse click to close a tab
- capture COMMAND+W (and windows/linux equivalent) to close tabs
96e019e
to
8426d96
Compare
7e30c69
to
34e0e5f
Compare
6eab9eb
to
f802655
Compare
it would be nice capture COMMAND+W (and windows/linux equivalent) to close tabs |
19d1d13
2807dd5
to
b9117cf
Compare
Update: (5e90726)
|
8e57033
to
89ae88e
Compare
@CurryYangxx, I took a pass at the branch again and tried after your commit and seems copying and moving seems to be working. I noticed one other thing - for example if you have 2 tabs open for 2 requests, and maybe you are working on pre-request/after-response scripts, or docs, or headers.... etc. in both, the moment you switch tabs, you are not redirected to the "sub-tab" you were at when browsing the request. So each time we switch between tabs we don't remember where inside the tab specifically the user was. |
f431f46
to
b93f004
Compare
1d3516e
to
f4cbf3c
Compare
Changes
TabList
andTab
Component, and import it in every type of file page.InsomniaTabContext
to manage state of the tabsuseInsomniaTab
hookshow-context-menu
toshow-nunjucks-context-menu
show-context-menu
as the common context menu methodrelated to #6108