Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(cli): failed to run script in cli if timeline dir is not inited #8232

Merged
merged 1 commit into from
Dec 5, 2024
Merged

fix(cli): failed to run script in cli if timeline dir is not inited #8232

merged 1 commit into from
Dec 5, 2024
+8 −0

Conversation

ihexxa
Copy link
Contributor

@ihexxa ihexxa commented Dec 5, 2024

Changes:

  • Init the path for persisting timeline file before executing script
  • Updated smoke tests

Ref: INS-4774

@ihexxa ihexxa self-assigned this Dec 5, 2024
@ihexxa ihexxa force-pushed the fix/cli/miss-timeline-dir branch from 725ac24 to 15e9872 Compare December 5, 2024 06:30
@ihexxa ihexxa changed the base branch from develop to release/10.2.1-beta.1 December 5, 2024 06:42
@ihexxa ihexxa force-pushed the fix/cli/miss-timeline-dir branch from 15e9872 to 8ad70cc Compare December 5, 2024 06:43
@ihexxa ihexxa requested a review from a team December 5, 2024 06:57
notjaywu
notjaywu approved these changes Dec 5, 2024
View reviewed changes
Copy link
Contributor

@notjaywu notjaywu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ihexxa ihexxa merged commit d1e39fd into release/10.2.1-beta.1 Dec 5, 2024
8 checks passed
@ihexxa ihexxa deleted the fix/cli/miss-timeline-dir branch December 5, 2024 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@notjaywu notjaywu notjaywu approved these changes

Assignees

@ihexxa ihexxa

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ihexxa @notjaywu