Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(build): add default condition to platform select() #11310

Merged
merged 1 commit into from
Jul 27, 2023

Conversation

flrgh
Copy link
Contributor

@flrgh flrgh commented Jul 27, 2023

Before this, non-Linux users would get this error:

(11:16:26) INFO: Current date is 2023-07-27
(11:16:26) ERROR: /path/path/path/path/external/openresty/BUILD.bazel:346:15: configurable attribute "configure_options" in @openresty//:openresty doesn't match this configuration. Would a default condition help?

Conditions checked:
 @platforms//os:linux

To see a condition's definition, run: bazel query --output=build <condition label>.

This instance of @openresty//:openresty has configuration identifier 77dabcd. To inspect its configuration, run: bazel config 77dabcd.

For more help, see https://bazel.build/docs/configurable-attributes#faq-select-choose-condition.

(11:16:26) ERROR: Analysis of target '//build:venv' failed; build aborted: 
(11:16:26) INFO: Elapsed time: 0.111s
(11:16:26) INFO: 0 processes.
(11:16:26) FAILED: Build did NOT complete successfully (0 packages loaded, 0 t\
argets configured)
source: no such file or directory: bazel-bin/build/kong-dev-venv.sh

@flrgh flrgh merged commit d5ef304 into master Jul 27, 2023
28 checks passed
@flrgh flrgh deleted the fix/bazel-select-default-platform branch July 27, 2023 18:34
flrgh added a commit that referenced this pull request Jul 27, 2023
flrgh added a commit that referenced this pull request Jul 27, 2023
(cherry picked from commit d5ef304)

Co-authored-by: Michael Martin <flrgh@protonmail.com>
@kikito kikito mentioned this pull request Aug 9, 2023
@outsinre
Copy link
Contributor

Is this required to be in EE?

@flrgh
Copy link
Contributor Author

flrgh commented Aug 14, 2023

Is this required to be in EE?

It was already merged to EE, but it looks like the commit was squashed into a different commit: https://github.com/Kong/kong-ee/commit/ca6b40ca3818275c02ab5e9dba57af52ea26d68a

Nevertheless, it is made obsolete by this change:
https://github.com/Kong/kong-ee/pull/6189

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants