[backport to release/3.3.x] fix(tracing): time precision, sampling rate, span hierarchy (#11484) #11650
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samugi
force-pushed
the
backport/11484
branch
from
d6f5481
to
929a880
Compare
samugi
changed the title
Closed
3 tasks
* fix(tracing): ensure sampling rate applies to whole trace This commit fixes a bug where the sampling rate was applied to individual spans, so configuring values of sampling_rate < 1 would sometimes result in split traces being reported. The fix ensures that the sampled flag that is calculated by the sampler for the root span is propagated to all children within the same trace. * fix(tracing): suggestions + propagation test
* fix an issue where the parent span was set incorrectly when the balancer instrumentation was disabled (the parent span was set to a temporary balancer span that was never reported)
* fix(tracing): span start/end time precision Ensure the span lifetime is consistent with the hierarchy by using the same time source for the root span's end time as the balancer span. Before this fix, an approximation (causing a precision error) could result in the root span to end before its children. * docs(changelog): add issue Co-authored-by: Xumin <100666470+StarlightIbuki@users.noreply.github.com> --------- Co-authored-by: Xumin <100666470+StarlightIbuki@users.noreply.github.com>
kikito
force-pushed
the
backport/11484
branch
from
929a880
to
8da193e
Compare
kikito
requested review from
Water-Melon and
StarlightIbuki
and removed request for
Water-Melon
kikito
approved these changes
Sep 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
backport of:
Checklist
CHANGELOG/unreleased/kongor addingskip-changeloglabel on PR if unnecessary. README.md (Please ping @vm-001 if you need help)There is a user-facing docs PR against https://github.com/Kong/docs.konghq.com - PUT DOCS PR HEREFull changelog
Issue reference
KAG-2336
Fix #11294 (secondary issue reported in the comments)