feat(patch): add tls.disable_http2_alpn() function needed patch for disabling HTTP/2 ALPN when tls handshake.
#13709
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
build/bazel
cherry-pick kong-ee
|
need a changelog |
|
Let's wait to merge Kong/lua-kong-nginx-module#93 first. |
oowl
changed the title
tls.disable_http2_alpn() function needed patch for disabling HTTP/2 ALPN when tls handshake.
oowl
force-pushed
the
disable-h2-alpn-re
branch
3 times, most recently
from
3ae4ce9
to
4e0e15f
Compare
3 tasks
Water-Melon
reviewed
Oct 8, 2024
Merged
3 tasks
Water-Melon
approved these changes
Oct 21, 2024
oowl
force-pushed
the
disable-h2-alpn-re
branch
from
4e0e15f
to
b666932
Compare
|
Successfully created cherry-pick PR for |
windmgc
pushed a commit
that referenced
this pull request
Nov 4, 2024
…es configured with AI-proxy. (#13735) This change will disable HTTP/2 ALPN handshake for connections on routes configured with AI-proxy. The following are the specific changes - move tls related function kong/tls/plugins/certificate.lua and kong/tls/plugins/sni_filter.lua from ee to ce repo - Based on feat(patch): add tls.disable_http2_alpn() function needed patch for disabling HTTP/2 ALPN when tls handshake. #13709 and feat: introduce tls.disable_http2_alpn() function lua-kong-nginx-module#93, we introduce the disable_http2_alpn action in the ai-proxy plugin to solve the ai-proxy plugin did not work in HTTP2 case. After the current PR is merged, HTTP/2 ALPN handshakes will be disabled for requests on routes configured with AI-proxy, and all these connections will fall back to the http1.1 protocol. AG-119
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Added
tls.disable_http2_alpn()function needed patch for disabling HTTP/2 ALPN when tls handshake.Sister PR Kong/lua-kong-nginx-module#93
Checklist
changelog/unreleased/kongorskip-changeloglabel added on PR if changelog is unnecessary. README.mdIssue reference
AG-119