Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(Bazel): format Bazel files by Bazel Buildifier #13720

Merged
merged 1 commit into from
Oct 8, 2024

Conversation

ADD-SP
Copy link
Contributor

@ADD-SP ADD-SP commented Sep 29, 2024

Summary

Format Bazel files using https://github.com/bazelbuild/buildtools/blob/main/buildifier/README.md.

Checklist

  • [N/A] The Pull Request has tests
  • [N/A] A changelog file has been created under changelog/unreleased/kong or skip-changelog label added on PR if changelog is unnecessary. README.md
  • [N/A] There is a user-facing docs PR against https://github.com/Kong/docs.konghq.com - PUT DOCS PR HERE

https://konghq.atlassian.net/browse/KAG-5491

@ADD-SP ADD-SP added skip-changelog incomplete-cherry-pick A cherry-pick was incomplete and needs manual intervention labels Sep 29, 2024
@github-actions github-actions bot added chore Not part of the core functionality of kong, but still needed build/bazel cherry-pick kong-ee schedule this PR for cherry-picking to kong/kong-ee labels Sep 29, 2024
@ADD-SP
Copy link
Contributor Author

ADD-SP commented Sep 29, 2024

@pull-request-size pull-request-size bot added size/M and removed size/L labels Sep 29, 2024
@ADD-SP ADD-SP marked this pull request as ready for review September 29, 2024 10:16
@team-gateway-bot team-gateway-bot added the author/community PRs from the open-source community (not Kong Inc) label Sep 29, 2024
@ADD-SP ADD-SP removed the author/community PRs from the open-source community (not Kong Inc) label Sep 29, 2024
@team-gateway-bot team-gateway-bot added the author/community PRs from the open-source community (not Kong Inc) label Sep 29, 2024
@ADD-SP ADD-SP removed the author/community PRs from the open-source community (not Kong Inc) label Sep 30, 2024
@team-gateway-bot team-gateway-bot added the author/community PRs from the open-source community (not Kong Inc) label Sep 30, 2024
@ADD-SP ADD-SP removed the cherry-pick kong-ee schedule this PR for cherry-picking to kong/kong-ee label Sep 30, 2024
@ADD-SP ADD-SP merged commit be4f07b into master Oct 8, 2024
52 checks passed
@ADD-SP ADD-SP deleted the add_sp/chore-fmt-bazel branch October 8, 2024 02:23
@ADD-SP ADD-SP removed author/community PRs from the open-source community (not Kong Inc) incomplete-cherry-pick A cherry-pick was incomplete and needs manual intervention labels Oct 8, 2024
@kikito kikito added the cherry-pick kong-ee schedule this PR for cherry-picking to kong/kong-ee label Nov 4, 2024
@team-gateway-bot
Copy link
Collaborator

Cherry-pick failed for master, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally.

git remote add upstream https://github.com/kong/kong-ee
git fetch upstream master
git worktree add -d .worktree/cherry-pick-13720-to-master-to-upstream upstream/master
cd .worktree/cherry-pick-13720-to-master-to-upstream
git checkout -b cherry-pick-13720-to-master-to-upstream
ancref=$(git merge-base 778fe086a1f46f44987dc17c984c3c0581996cbb 2a31bc716eb2f314bbc75d3f3b065ede6b1c2bcb)
git cherry-pick -x $ancref..2a31bc716eb2f314bbc75d3f3b065ede6b1c2bcb

@github-actions github-actions bot added the incomplete-cherry-pick A cherry-pick was incomplete and needs manual intervention label Nov 4, 2024
@kikito
Copy link
Member

kikito commented Nov 12, 2024

cherrypick in https://github.com/Kong/kong-ee/pull/10388

@kikito kikito removed the incomplete-cherry-pick A cherry-pick was incomplete and needs manual intervention label Nov 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build/bazel cherry-pick kong-ee schedule this PR for cherry-picking to kong/kong-ee chore Not part of the core functionality of kong, but still needed size/M skip-changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants