Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(build): fix exec script of LuaRocks on macOS #13782

Merged
merged 1 commit into from
Oct 24, 2024

Conversation

ADD-SP
Copy link
Contributor

@ADD-SP ADD-SP commented Oct 24, 2024

Summary

Create symbolic links against .dylib instead of .so on macOS.

Cherry-pick to EE: https://github.com/Kong/kong-ee/pull/10522

Checklist

  • [N/A] The Pull Request has tests
  • [N/A] A changelog file has been created under changelog/unreleased/kong or skip-changelog label added on PR if changelog is unnecessary. README.md
  • [N/A] There is a user-facing docs PR against https://github.com/Kong/docs.konghq.com - PUT DOCS PR HERE

Issue reference

KAG-5571

@github-actions github-actions bot added build/bazel cherry-pick kong-ee schedule this PR for cherry-picking to kong/kong-ee labels Oct 24, 2024
@ADD-SP ADD-SP removed the cherry-pick kong-ee schedule this PR for cherry-picking to kong/kong-ee label Oct 24, 2024
@ADD-SP ADD-SP marked this pull request as ready for review October 24, 2024 02:39
@team-gateway-bot team-gateway-bot added the author/community PRs from the open-source community (not Kong Inc) label Oct 24, 2024
@ADD-SP ADD-SP removed the author/community PRs from the open-source community (not Kong Inc) label Oct 24, 2024
@ADD-SP ADD-SP merged commit 7599271 into master Oct 24, 2024
57 checks passed
@ADD-SP ADD-SP deleted the add_sp/chore-fix-build-libexpat branch October 24, 2024 03:05
@kikito kikito added the cherry-pick kong-ee schedule this PR for cherry-picking to kong/kong-ee label Nov 4, 2024
@kikito
Copy link
Member

kikito commented Nov 4, 2024

cherrypick in https://github.com/Kong/kong-ee/pull/10522

@team-gateway-bot
Copy link
Collaborator

Cherry-pick failed for master, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally.

git remote add upstream https://github.com/kong/kong-ee
git fetch upstream master
git worktree add -d .worktree/cherry-pick-13782-to-master-to-upstream upstream/master
cd .worktree/cherry-pick-13782-to-master-to-upstream
git checkout -b cherry-pick-13782-to-master-to-upstream
ancref=$(git merge-base 9a5353e4f1bd2a6019a2b7ae8870a253e29eefc2 af22dcb9a741c29b888b2915b89beb7388060128)
git cherry-pick -x $ancref..af22dcb9a741c29b888b2915b89beb7388060128

@github-actions github-actions bot added the incomplete-cherry-pick A cherry-pick was incomplete and needs manual intervention label Nov 4, 2024
@kikito kikito removed the incomplete-cherry-pick A cherry-pick was incomplete and needs manual intervention label Nov 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build/bazel cherry-pick kong-ee schedule this PR for cherry-picking to kong/kong-ee size/S skip-changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants