refactor(clustering): dont generate event for full sync #13854
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
core/clustering
cherry-pick kong-ee
chobits
reviewed
Nov 12, 2024
StarlightIbuki
approved these changes
Nov 12, 2024
| @@ -277,7 +275,10 @@ local function do_sync() | |||
| ", version: ", delta_version, | |||
| ", type: ", delta_type) | |||
|
|
|||
| ev = { delta_type, crud_event_type, delta_entity, old_entity, } | |||
| -- wipe the whole lmdb, should not have events | |||
There was a problem hiding this comment.
This is worth refactoring. Let's find a better form of the code.
chobits
approved these changes
Nov 13, 2024
|
Successfully created cherry-pick PR for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
KAG-5804
Checklist
changelog/unreleased/kongorskip-changeloglabel added on PR if changelog is unnecessary. README.mdIssue reference
Fix #[issue number]